Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: organize phases cmd #73725

Merged

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Feb 4, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Reorganize cmd for phases, by separating init phases and join phases

Which issue(s) this PR fixes:
none

Special notes for your reviewer:
While splitting the control-plane-prepare phase, I simplified the manifest subphase in order to avoid the third level of nested phases (if we want to add this, we should do this consistently for certs, kubeconfig and manifests)

Does this PR introduce a user-facing change?:

NONE

/sig cluster-lifecycle
/area kubeadm
/priority backlog
@kubernetes/sig-cluster-lifecycle-pr-reviews
/assign @neolit123
/assign @ereslibre
@MalloZup

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 4, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 4, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. area/kubeadm priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2019
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fabriziopandini
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2019
@ereslibre
Copy link
Contributor

/lgtm

@fabriziopandini fabriziopandini changed the title [WIP] kubeadm: organize phases cmd kubeadm: organize phases cmd Feb 5, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 5, 2019
@fabriziopandini
Copy link
Member Author

Removing WIP as per comments/feedbacks on slack

@k8s-ci-robot k8s-ci-robot merged commit 28fefba into kubernetes:master Feb 5, 2019
@chuckha
Copy link
Contributor

chuckha commented Feb 5, 2019

@fabriziopandini was there an issue for this or could you link to slack where this discussion took place? I'm interested in knowing the reason behind this work. It looks very relevant to this comment I made yesterday: kubernetes/kubeadm#1375 (comment)

@fabriziopandini
Copy link
Member Author

fabriziopandini commented Feb 5, 2019

@chuckha here it is the thread for better visibility, I'm going to add a comment to 1375

@fabriziopandini

Hi all, just sent #73725
It re-organize phases, by splitting init phases and join phases + I simplified
the manifest subphase in order to avoid the third level of nested phases (if we want to
add this, we should do this consistently for certs, kubeconfig and manifests)
it is still a WIP because those are changes not agreed before
let me know if you are fine with those changes or not

@neolit123

i think this is great 👍

@ereslibre

  1. I think subdirectories as you did is a better approach than sibling files as I first started,
  2. I think it makes sense to remove the subphases for manifests because we are not coherent
    with subphases in certs and kubeconfig so yes, 👍 from me, the organization is clearly better

@fabriziopandini fabriziopandini deleted the kubeadm-organize-phases branch February 13, 2019 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants