-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: organize phases cmd #73725
kubeadm: organize phases cmd #73725
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fabriziopandini
/lgtm
/lgtm |
Removing WIP as per comments/feedbacks on slack |
@fabriziopandini was there an issue for this or could you link to slack where this discussion took place? I'm interested in knowing the reason behind this work. It looks very relevant to this comment I made yesterday: kubernetes/kubeadm#1375 (comment) |
@chuckha here it is the thread for better visibility, I'm going to add a comment to 1375
|
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Reorganize cmd for phases, by separating init phases and join phases
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
While splitting the control-plane-prepare phase, I simplified the manifest subphase in order to avoid the third level of nested phases (if we want to add this, we should do this consistently for certs, kubeconfig and manifests)
Does this PR introduce a user-facing change?:
/sig cluster-lifecycle
/area kubeadm
/priority backlog
@kubernetes/sig-cluster-lifecycle-pr-reviews
/assign @neolit123
/assign @ereslibre
@MalloZup