Ensure conditional validation has knowledge of old and new object #73774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
liggitt
added
the
priority/important-soon
k8s-ci-robot
added
sig/apps
12 tasks
sbezverk
reviewed
Feb 6, 2019
| return fields | ||
| } | ||
|
|
||
| // ValidateConditionalPodTemplate validates conditionally valid fields. |
There was a problem hiding this comment.
I could not find Unit tests for ValidateConditionalPodTemplate any particular reason it does not need one?
There was a problem hiding this comment.
both ValidateConditionalPodTemplate and ValidateConditionalPod route to validateConditionalPodSpec, where the validation logic lives, so I just added tests for the latter.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sbezverk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Moves conditional validation to methods with knowledge of the old and new object, to ensure we never fail an object based on a validation check of data which is already in the existing persisted object.
This ensures that once the SCTP feature is enabled, rollback of one version is safe (API validation-wise).
Which issue(s) this PR fixes:
Finishes #72651
Does this PR introduce a user-facing change?:
/sig api-machinery
/cc @sbezverk