ControllerRef creation through factory function

[Adirio]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
The following controllers were duplicating the factory function for ControllerRefs:

• ReplicaSetController
• fakeHistory
• defaultStatefulSetControl

Special notes for your reviewer:
The following controllers already used the factory function:

• CronJobController: here
• DaemonSetsController: here, here and here
• DeploymentController: here
• JobController: here
• defaultStatefulSetControl: here
• SampleController: here
• Controllers build with kubebuilder: here

Does this PR introduce a user-facing change?:

NONE

[k8s-ci-robot]

Hi @Adirio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Adirio]

/assign @enisoc as owns both files

[k8s-ci-robot]

@Adirio: GitHub didn't allow me to assign the following users: as, owns, both, files.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @enisoc as owns both files

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Adirio]

/priority important-longterm

[enisoc]

/ok-to-test
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, enisoc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controller/history/OWNERS [enisoc]
• pkg/controller/replicaset/OWNERS [enisoc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Adirio]

@enisoc can you add LGTM label again please? Tests complained about a line that was not changed.

[enisoc]

/lgtm