Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubemark windows num nodes #73813

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Fix kubemark windows num nodes #73813

merged 1 commit into from
Feb 7, 2019

Conversation

wojtek-t
Copy link
Member

@wojtek-t wojtek-t commented Feb 7, 2019

Currently, we are seeing lines like this in kubemark test runs:

07 11:48:19.759] ./test/kubemark/../../test/kubemark/gce/../../../cluster/gce/config-common.sh: line 23: 500 + : syntax error: operand expected (error token is "+ ")
W0207 11:48:19.762] ./test/kubemark/../../test/kubemark/gce/../../../cluster/gce/config-common.sh: line 23: 500 + : syntax error: operand expected (error token is "+ ")
W0207 11:48:19.763] ./test/kubemark/../../test/kubemark/gce/../../../cluster/gce/config-common.sh: line 23: 500 + : syntax error: operand expected (error token is "+ ")
W0207 11:48:19.766] ./test/kubemark/../../test/kubemark/gce/../../../cluster/gce/config-common.sh: line 23: 500 + : syntax error: operand expected (error token is "+ ")
W0207 11:48:19.768] ./test/kubemark/../../test/kubemark/gce/../../../cluster/gce/config-common.sh: line 23: 500 + : syntax error: operand expected (error token is "+ ")
W0207 11:48:19.770] ./test/kubemark/../../test/kubemark/gce/../../../cluster/gce/config-common.sh: line 23: 500 + : syntax error: operand expected (error token is "+ ")
W0207 11:48:19.772] ./test/kubemark/../../test/kubemark/gce/../../../cluster/gce/config-common.sh: line 23: 500 + : syntax error: operand expected (error token is "+ ")
W0207 11:48:19.773] ./test/kubemark/../../test/kubemark/gce/../../../cluster/gce/config-common.sh: line 23: 500 + : syntax error: operand expected (error token is "+ ")

@k8s-ci-robot
Copy link
Contributor

@wojtek-t: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2019
@wojtek-t wojtek-t added sig/scalability Categorizes an issue or PR as relevant to SIG Scalability. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@wojtek-t wojtek-t added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2019
@k8s-ci-robot k8s-ci-robot added the sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. label Feb 7, 2019
@krzysied
Copy link
Contributor

krzysied commented Feb 7, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@wojtek-t wojtek-t added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit a0aa222 into kubernetes:master Feb 7, 2019
@wojtek-t wojtek-t deleted the fix_kubemark_nodes branch July 5, 2019 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmarek gmarek Awaiting requested review from gmarek

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

Assignees

@shyamjvs shyamjvs

@krzysied krzysied

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/scalability Categorizes an issue or PR as relevant to SIG Scalability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wojtek-t @k8s-ci-robot @krzysied @shyamjvs