Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ioutil.TempDir for temporary dir creation #73816

Merged
merged 1 commit into from
Feb 7, 2019
Merged

Use ioutil.TempDir for temporary dir creation #73816

merged 1 commit into from
Feb 7, 2019

Conversation

mkumatag
Copy link
Member

@mkumatag mkumatag commented Feb 7, 2019 •
edited

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #73689

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2019
@mkumatag
Copy link
Member Author

mkumatag commented Feb 7, 2019

/cc @liggitt

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2019
@mkumatag mkumatag mentioned this pull request Feb 7, 2019
Closed
@liggitt
Copy link
Member

liggitt commented Feb 7, 2019

needs hack/update-bazel.sh run

@spiffxp
Copy link
Member

spiffxp commented Feb 7, 2019

/priority critical-urgent
/sig api-machinery
(they own cmd)

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2019
@liggitt
Copy link
Member

liggitt commented Feb 7, 2019

/sig api-machinery
(they own cmd)

really? I'd have guessed kube-proxy tests would belong to sig-network

@mkumatag mkumatag changed the title Use ioutil.TempDir for temporary dir creating Use ioutil.TempDir for temporary dir creation Feb 7, 2019
@liggitt
Copy link
Member

liggitt commented Feb 7, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 9200456 into kubernetes:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@mikedanese mikedanese Awaiting requested review from mikedanese

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes unit tests failing due to build failure
4 participants
@mkumatag @liggitt @spiffxp @k8s-ci-robot