Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e upgrade test: rename functions to match f0f78299348afcf770d4e8d89dcea82f80811b28 #73822

Merged
merged 1 commit into from
Feb 14, 2019
Merged

e2e upgrade test: rename functions to match f0f78299348afcf770d4e8d89dcea82f80811b28 #73822

merged 1 commit into from
Feb 14, 2019

Conversation

justinsb
Copy link
Member

@justinsb justinsb commented Feb 7, 2019

These functions were renamed in
f0f7829, but cluster/gce/upgrade.sh
was missed.

Issue #73705
Issue #73696

/kind bug

NONE

@justinsb
e2e upgrade test: rename functions to match f0f7829
28c34d8 
These functions were renamed in
f0f7829, but cluster/gce/upgrade.sh
was missed.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2019
@justinsb justinsb mentioned this pull request Feb 7, 2019
Closed
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 7, 2019
@justinsb justinsb mentioned this pull request Feb 7, 2019
Closed
@justinsb
Copy link
Member Author

justinsb commented Feb 7, 2019

cc @pjh

@justinsb
Copy link
Member Author

justinsb commented Feb 7, 2019

/retest

I don't think my changes are in these code paths!

@pjh
Copy link
Contributor

pjh commented Feb 7, 2019

LGTM, sorry for the breakage :(

yujuhong is OOO and so won't be able to review/approve until next week.

neolit123
neolit123 approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @justinsb !

/lgtm
/priority critical-urgent
/kind failing-test
/assign @vishh

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 8, 2019
@pjh
Copy link
Contributor

pjh commented Feb 14, 2019

/retest

@yujuhong
Copy link
Contributor

/lgtm
/approve

@justinsb thanks for fixing this!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6f6f8bd into kubernetes:master Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 approved these changes

@MaciekPytel MaciekPytel Awaiting requested review from MaciekPytel

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@neolit123 neolit123

@vishh vishh

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@justinsb @pjh @yujuhong @k8s-ci-robot @neolit123 @vishh