Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Add comments on cadvisor implementations #73829

Merged
merged 1 commit into from Jul 30, 2019
Merged

Fix/Add comments on cadvisor implementations #73829

merged 1 commit into from Jul 30, 2019

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Feb 7, 2019 •
edited

What type of PR is this?

/kind cleanup
/kind documentation

What this PR does / why we need it:

  • Fix a misleading comment in cadvisor_linux.
  • Add an explanation on why a parameter is not being used in cadvisor_windows, according to some reading of the code (need validation).
  • Fix lint errors in pkg/kubelet/cadvisor and pkg/kubelet/cadvisor/testing (Fix golint failures #68026)

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/documentation Categorizes issue or PR as related to documentation. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 7, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @alculquicondor. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 7, 2019
@k8s-ci-robot k8s-ci-robot added area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 7, 2019
@alculquicondor
Copy link
Member Author

/assign @Random-Liu

neolit123
neolit123 reviewed Feb 8, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR @alculquicondor
added one minor comment.

/priority backlog
/ok-to-test

pkg/kubelet/cadvisor/cadvisor_windows.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 8, 2019
@alculquicondor
Copy link
Member Author

/test pull-kubernetes-integration
/test pull-kubernetes-local-e2e-containerized

@alculquicondor
Copy link
Member Author

/test pull-kubernetes-local-e2e-containerized

2 similar comments
@alculquicondor
Copy link
Member Author

/test pull-kubernetes-local-e2e-containerized

@alculquicondor
Copy link
Member Author

/test pull-kubernetes-local-e2e-containerized

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 11, 2019
@alculquicondor
Copy link
Member Author

I fixed lint errors to make the PR more relevant.

@alculquicondor
Copy link
Member Author

/test pull-kubernetes-local-e2e-containerized

/test pull-kubernetes-e2e-gce-100-performance

@alculquicondor
Copy link
Member Author

/test pull-kubernetes-local-e2e-containerized

@oomichi
Copy link
Member

oomichi commented Feb 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2019
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 9, 2019
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 10, 2019
@Random-Liu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@alculquicondor
Copy link
Member Author

/assign @vishh

for hack/.golint_failures

@oomichi
Copy link
Member

oomichi commented Jul 26, 2019

@alculquicondor Unfortunately this seems necessary to be rebased for the latest master.
Could you do that?

@alculquicondor
Fix/Add comments on cadvisor implementations
a626a29 
Fix lint issues.

Signed-off-by: Aldo Culquicondor <acondor@google.com>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2019
@dims
Copy link
Member

dims commented Jul 29, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, dims, Random-Liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2019
@alculquicondor
Copy link
Member Author

/test pull-kubernetes-local-e2e-containerized
/test pull-kubernetes-e2e-gce

@dims
Copy link
Member

dims commented Jul 29, 2019

/test pull-kubernetes-bazel-test
/test pull-kubernetes-integration

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 30, 2019 •
edited

@alculquicondor: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-local-e2e-containerized 83e79623dc633ff3390eedbe20dea47b550bc840 link /test pull-kubernetes-local-e2e-containerized

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@alculquicondor
Copy link
Member Author

/test pull-kubernetes-bazel-build

@k8s-ci-robot k8s-ci-robot merged commit 4c191fd into kubernetes:master Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@krmayankk krmayankk Awaiting requested review from krmayankk

@sjpotter sjpotter Awaiting requested review from sjpotter

Assignees

@dims dims

@oomichi oomichi

@Random-Liu Random-Liu

@vishh vishh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@alculquicondor @k8s-ci-robot @oomichi @Random-Liu @dims @fejta-bot @neolit123 @vishh