Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit the list of scheduling maintainers to active members of the sig #73862

Merged
merged 1 commit into from
Feb 22, 2019
Merged

Limit the list of scheduling maintainers to active members of the sig #73862

merged 1 commit into from
Feb 22, 2019

Conversation

bsalamat
Copy link
Member

@bsalamat bsalamat commented Feb 8, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

/sig scheduling

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 8, 2019
@liggitt
Copy link
Member

liggitt commented Feb 8, 2019

/assign @k82cn
cc @davidopp @timothysc @aveshagarwal

timothysc
timothysc approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Feb 8, 2019
@bsalamat
Copy link
Member Author

bsalamat commented Feb 8, 2019

Since @davidopp may not check his github notifications, I let him know about this and he said he was fine with it.

@bsalamat bsalamat added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 8, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-kind Indicates a PR lacks a `kind/foo` label and requires one. label Feb 8, 2019
@bsalamat bsalamat added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 8, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 8, 2019
@k82cn
Copy link
Member

k82cn commented Feb 9, 2019

/lgtm :)

@timothysc
Copy link
Member

timeout

/hold cancel

godspeed sig-scheduling!

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2019
@liggitt
Copy link
Member

liggitt commented Feb 14, 2019

/approve
/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, liggitt, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@dims
Copy link
Member

dims commented Feb 18, 2019

/retest

@bsalamat bsalamat added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed priority/backlog Higher priority than priority/awaiting-more-evidence. labels Feb 20, 2019
@bsalamat
Copy link
Member Author

/retest

@bsalamat
Copy link
Member Author

Hmm... not sure why this is not getting merged. In fact not all the tests run.
@spiffxp Do you know why?

@spiffxp
Copy link
Member

spiffxp commented Feb 21, 2019

/retest
No I'm not entirely clear why, retriggering to see if this helps

@spiffxp
Copy link
Member

spiffxp commented Feb 21, 2019

/test all
Doesn't seem like /retest had any effect

@spiffxp
Copy link
Member

spiffxp commented Feb 21, 2019

OK that kicked them off. TIL, use /test if the things are claiming "Pending - Job triggered" but they're actually dirty liars.

@k8s-ci-robot k8s-ci-robot merged commit 2e531f4 into kubernetes:master Feb 22, 2019
@bsalamat bsalamat deleted the maintainers branch February 22, 2019 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@timothysc timothysc

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@bsalamat @liggitt @k82cn @timothysc @k8s-ci-robot @dims @spiffxp