Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic server-side apply test to test-cmd #73866

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Add basic server-side apply test to test-cmd #73866

merged 1 commit into from
Feb 20, 2019

Conversation

apelisse
Copy link
Member

@apelisse apelisse commented Feb 9, 2019

What type of PR is this?
/kind cleanup

Does this PR introduce a user-facing change?:

NONE

/assign @jennybuckley @kwiesmueller

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 9, 2019
@apelisse
Copy link
Member Author

apelisse commented Feb 9, 2019

/assign @soltysh

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 9, 2019
@apelisse
Copy link
Member Author

/retest

soltysh
soltysh approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2019
@kwiesmueller
Copy link
Member

/retest

@apelisse apelisse closed this Feb 20, 2019
@apelisse apelisse reopened this Feb 20, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d60b7d6 into kubernetes:master Feb 20, 2019
@Katharine Katharine mentioned this pull request Feb 21, 2019
Merged
@spiffxp spiffxp mentioned this pull request Feb 23, 2019
Closed
spiffxp
spiffxp reviewed Feb 23, 2019
View reviewed changes
hack/make-rules/test-cmd.sh
@@ -41,7 +41,7 @@ function run_kube_apiserver() {
AUTHORIZATION_MODE="RBAC,AlwaysAllow"

# Enable features
ENABLE_FEATURE_GATES="DryRun=true"
ENABLE_FEATURE_GATES="ServerSideApply=true"
Copy link
Member

@spiffxp spiffxp Feb 23, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is causing run_kubectl_run_tests to flake (ref: #74431) EDIT: after rollback, I've been unable to repro

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disregard, it works fine, I'm off to bisect beyond this PR

@apelisse
Copy link
Member Author

apelisse commented Feb 23, 2019 via email

@spiffxp
Copy link
Member

spiffxp commented Feb 23, 2019

I have a few occurrences of the flake linked in the linked issue... I'm trying to repro and bisect locally, and I'm not yet certain it's this PR, I'll keep you posted

@apelisse
Copy link
Member Author

Thanks, I missed it from my phone. Trying to look at it too.

@spiffxp
Copy link
Member

spiffxp commented Feb 23, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@soltysh soltysh soltysh approved these changes

@gmarek gmarek Awaiting requested review from gmarek

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@soltysh soltysh

@kwiesmueller kwiesmueller

@jennybuckley jennybuckley

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@apelisse @k8s-ci-robot @kwiesmueller @fejta-bot @spiffxp @soltysh @jennybuckley