-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip validation for clusterCIDR in node ipam controller. #73869
Skip validation for clusterCIDR in node ipam controller. #73869
Conversation
Hi @grayluck. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/priority backlog |
/assign @freehan |
/priority important-soon |
/ok-to-test |
/retest |
/approve |
/assign @bowei for approval |
@freehan: GitHub didn't allow me to assign the following users: for, approval. Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @bowei for approval |
@grayluck: GitHub didn't allow me to assign the following users: for, approval. Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
clusterCIDR is passed down from kube_env CLUSTER_IP_RANGE to the flag --cluster-cidr. We plan not to let GKE to pass down CLUSTER_IP_RANGE to kube-env for the master node.
6f6c2e7
to
7379ad5
Compare
/lgtm how did this come up? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan, grayluck The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I found this issue when I am tracing how master node uses CLUTSER_IP_RANGE env and ends up here. As we removed the /24 limit in previous PR, we should also remove the validation against clusterCIDR for cloud allocator. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
When CIDRAllocationType == ipam.CloudAllocatorType, clusterCIDR will not be used but decided at the cloud provider side. Thus we should not validate against clusterCIDR, and allow clusters with an nil clusterCIDR.
clusterCIDR is passed down from kube_env CLUSTER_IP_RANGE to the flag --cluster-cidr.
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
/assign @freehan