Fix PVC protection e2es when default storage class is WaitForFirstConsumer #73928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/sig storage |
k8s-ci-robot
added
sig/storage
gnufied
reviewed
Feb 11, 2019
|
/lgtm /assign @msau42 |
k8s-ci-robot
added
the
lgtm
msau42
reviewed
Feb 11, 2019
wongma7
force-pushed
the
protection-waitforfirstconsumer
branch
from
9380669
to
2f981fa
Compare
k8s-ci-robot
added
size/S
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it: Currently, when the default StorageClass has volumeBindingMode WaitForFirstConsumer, these tests will wait for the PVC to bind when it never will. To get around this, create a temporary duplicate StorageClass with mode Immediate for the test
Which issue(s) this PR fixes
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: