Remove unnecessary prefixes from various .import-restrictions files #73932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
|
/assign @liggitt @neolit123 |
|
only tightens allowed prefixes /lgtm |
k8s-ci-robot
added
lgtm
Found using script: https://gist.github.com/dims/384dea60754042f61d79233603034038 Just run using: `find . -name .import-restrictions | xargs python ~/junk/sanitize-import-boss.py` The removed entries are either packages that got moved/renamed/deleted but are still not cleaned up from .import-restrictions files. Change-Id: I92c400f74e6f012cc75539311ed4de280e25e918
dims
force-pushed
the
cleanup-unnecessary-packages-from-import-restrictions
branch
from
3c8f27f
to
1d430a4
Compare
k8s-ci-robot
removed
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
whoops. had to add a couple back (mac vs linux issue) |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Found using script:
https://gist.github.com/dims/384dea60754042f61d79233603034038
Just run using:
find . -name .import-restrictions | xargs python sanitize-import-boss.pyThe removed entries are either packages that got moved/renamed/deleted
but are still not cleaned up from .import-restrictions files.
Change-Id: I92c400f74e6f012cc75539311ed4de280e25e918
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: