-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the dependency pmezard/go-difflib #73941
Conversation
/sig cluster-lifecycle |
Will review after tests pass. |
6af2a99
to
dcda4d9
Compare
A fmt.Sprintf() bug was fixed upstream. Use the latest SHA from upstream.
dcda4d9
to
76ed556
Compare
@cblecker relevant CI seems to have passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks for figuring out how to do this!
the existing process assumes a fast computer with fast internet. |
/lgtm |
@neolit123 right the existing docs is a hammer, but once you get the hang of it ... you can do a bunch of simple things by hand |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
A fmt.Sprintf() bug was fixed upstream.
Use the latest SHA from upstream.
Which issue(s) this PR fixes:
Fixes kubernetes/kubeadm#1368
Special notes for your reviewer:
followed the guide here:
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/godep.md
but
hack/run-in-gopath.sh hack/godep-save.sh
fails for me with:so i sort of bootlegged the update.
Does this PR introduce a user-facing change?:
/assign @dims @cblecker
/cc @chuckha
/area kubeadm
/kind bug
/priority important-soon