Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: remove nodefs.inodesFree test defaulting on non-Linux #73945

Merged
merged 1 commit into from
Feb 12, 2019
Merged

kubeadm: remove nodefs.inodesFree test defaulting on non-Linux #73945

merged 1 commit into from
Feb 12, 2019

Conversation

neolit123
Copy link
Member

What this PR does / why we need it:
Add test files that exclude the field in question
under KubeletConfiguration -> evictionHard for non-Linux.

Add runtime abstraction for the test files in initconfiguration_tests.go

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1398

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

/cc @chuckha @feiskyer
/assign @fabriziopandini @rosti
/kind bug
/priority important-soon

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 12, 2019
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 12, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 12, 2019
@neolit123
Copy link
Member Author

/area kubeadm
/sig cluster-lifecycle

@chuckha
could you please try this PR?

e.g:

wget https://github.com/kubernetes/kubernetes/pull/73945.diff
git apply 73945.diff
go test cmd/kubeadm/app/util/config/...

on windows i'm getting import path problems and i don't have a mac.

@yagonobre
Copy link
Member

@neolit123 I tested on osx 10.14.3 and it's work

go test k8s.io/kubernetes/cmd/kubeadm/app/util/config/...
ok      k8s.io/kubernetes/cmd/kubeadm/app/util/config   9.625s
ok      k8s.io/kubernetes/cmd/kubeadm/app/util/config/strict    (cached)

@neolit123
Copy link
Member Author

thanks @yagonobre !

feiskyer
feiskyer reviewed Feb 12, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the fix

@neolit123
kubeadm: remove nodefs.inodesFree test defaulting on non-Linux
19e89c3 
Add test files that exclude the field in question
under KubeletConfiguration -> evictionHard for non-Linux.

Add runtime abstraction for the test files in initconfiguration_tests.go
@neolit123
Copy link
Member Author

/retest

chuckha
chuckha approved these changes Feb 12, 2019
View reviewed changes
Copy link
Contributor

@chuckha chuckha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2019
@chuckha
Copy link
Contributor

chuckha commented Feb 12, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 51f5164 into kubernetes:master Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@chuckha chuckha chuckha approved these changes

Assignees

@chuckha chuckha

@rosti rosti

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix broken initconfiguration unit tests on non-linux
7 participants
@neolit123 @k8s-ci-robot @yagonobre @chuckha @feiskyer @rosti @fabriziopandini