-
Notifications
You must be signed in to change notification settings - Fork 38.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repo-infra, bazel-skylib, and rules_docker dependencies #73983
Conversation
/priority important-soon |
Also require bazel 0.18.0+
1e2f861
to
e216995
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
1 similar comment
/retest |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
comment is wrong, only local-e2e failed, the rest are green.. 😕 |
/cc @cheftako |
What type of PR is this?
/kind cleanup
What this PR does / why we need it: this is basically the first commit of #73930, pulled out into a separate PR to separate the update changes from the cross-compilation changes.
Why we're updating:
@io_kubernetes_build
to the more accurate@io_k8s_repo_infra
. The update in this PR isn't pulling in any functional changes, just the rename.container_pull
. There are other internal changes, hence a lot of cleanup in various build filesrules_go 0.17.0 now requires bazel 0.18.0, so ratchet to that. (We could probably ratchet to something even later; I think Prow is running 0.21.0.)
Does this PR introduce a user-facing change?:
/assign @fejta @BenTheElder