Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint failures on cmd/kubeadm/app #73992

Merged
merged 1 commit into from
Feb 13, 2019
Merged

Fix golint failures on cmd/kubeadm/app #73992

merged 1 commit into from
Feb 13, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Feb 13, 2019 •
edited

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
fix golint failures on cmd/kubeadm/app

Which issue(s) this PR fixes:
Ref #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 13, 2019
yagonobre
yagonobre reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @SataQiu, thanks for you pr.
Can you change your pr description from Fixes #68026 to Ref #68026?

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Feb 13, 2019

@yagonobre Thank you! I have modified the description.

neolit123
neolit123 reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/kind cleanup
/remove-priority important-longterm
/priority backlog
/hold

@kubernetes/sig-cluster-lifecycle-pr-reviews
objections?

cmd/kubeadm/app/kubeadm.go
@@ -21,6 +21,8 @@ import (
"os"

"github.com/spf13/pflag"

// ensure libs have a chance to globally register their flags
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change to:

// allow klog to register its global flags

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Feb 13, 2019
yagonobre
yagonobre reviewed Feb 13, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the new comment

@neolit123
Copy link
Member

/assign @fejta

this is just a small lint fix. needs approve for /hack.
thanks.

@fejta
Copy link
Contributor

fejta commented Feb 13, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, neolit123, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2019
@neolit123
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Feb 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit 07428f7 into kubernetes:master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@yagonobre yagonobre yagonobre left review comments

@dixudx dixudx Awaiting requested review from dixudx

@gmarek gmarek Awaiting requested review from gmarek

Assignees

@neolit123 neolit123

@fejta fejta

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@SataQiu @neolit123 @fejta @k8s-ci-robot @yagonobre