Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update generated files #74012

Merged
merged 1 commit into from
Feb 14, 2019
Merged

update generated files #74012

merged 1 commit into from
Feb 14, 2019

Conversation

danielqsj
Copy link
Contributor

What type of PR is this?

/kind bug
/sig api-machinery

What this PR does / why we need it:

make verify job passed.

Which issue(s) this PR fixes:

Fixes #73999

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 13, 2019
@k8s-ci-robot k8s-ci-robot added the kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API label Feb 13, 2019
@mattjmcnaughton mattjmcnaughton mentioned this pull request Feb 13, 2019
Merged
@danielqsj
Copy link
Contributor Author

/test pull-kubernetes-godeps

@danielqsj
Copy link
Contributor Author

cc @liggitt

@liggitt
Copy link
Member

liggitt commented Feb 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielqsj, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2019
@liggitt
Copy link
Member

liggitt commented Feb 14, 2019

How did this get out of sync in master?

@danielqsj
Copy link
Contributor Author

not sure about it. But it missing for several months.
Should it be cherry-picked to release branch ?

@k8s-ci-robot k8s-ci-robot merged commit 2b9c915 into kubernetes:master Feb 14, 2019
@liggitt liggitt added this to the v1.14 milestone Jun 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikedanese mikedanese Awaiting requested review from mikedanese

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

Master-blocking failing tests: verify.godeps and verify.staging-godeps
3 participants
@danielqsj @liggitt @k8s-ci-robot