Add missing VisitArbitrary methods in kubectl explain #74029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
priority/important-longterm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
apelisse
reviewed
Feb 14, 2019
pkg/kubectl/explain/field_lookup.go
Outdated
| @@ -89,6 +89,12 @@ func (f *fieldLookup) VisitKind(k *proto.Kind) { | |||
| subSchema.Accept(f) | |||
| } | |||
|
|
|||
| func (f *fieldLookup) VisitArbitrary(a *proto.Arbitrary) { | |||
| if f.SaveLeafSchema(a) { | |||
There was a problem hiding this comment.
f.Schema = a would be more accurate (note that the condition is pointless).
|
lgtm after nit, thanks @soltysh ! |
soltysh
force-pushed
the
explain_nil2
branch
from
10d2f10
to
22a3f6d
Compare
|
Updated, @apelisse ptal |
|
Thank you! |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/priority important-longterm
/sig cli
What this PR does / why we need it:
This is alternative approach to #73817 and I think is a better one.
Which issue(s) this PR fixes:
This was noticed in #71192
Special notes for your reviewer:
/assign @liggitt @sttts @roycaihw @apelisse
Does this PR introduce a user-facing change?: