Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golint failures on cmd/kubeadm/app/util/config #74053

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Fix golint failures on cmd/kubeadm/app/util/config #74053

merged 1 commit into from
Feb 15, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Feb 14, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
fix golint failures on cmd/kubeadm/app/util/config

Which issue(s) this PR fixes:
Ref #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 14, 2019
@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 14, 2019
@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 14, 2019
yagonobre
yagonobre reviewed Feb 14, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SataQiu
/priority backlog
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 14, 2019
rosti
rosti approved these changes Feb 14, 2019
View reviewed changes
Copy link
Contributor

@rosti rosti left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @SataQiu !
/lgtm

neolit123
neolit123 reviewed Feb 14, 2019
View reviewed changes
cmd/kubeadm/app/util/config/initconfiguration_test.go
master_defaultedYAML = "testdata/defaulting/master/defaulted.yaml"
master_defaultedYAMLNonLinux = "testdata/defaulting/master/defaulted_non_linux.yaml"
master_invalidYAML = "testdata/validation/invalid_mastercfg.yaml"
masterV1alpha3YAML = "testdata/conversion/master/v1alpha3.yaml"
Copy link
Member

@neolit123 neolit123 Feb 14, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a follow up PR we should rename master and the folder names to controlplane or something better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 Thanks! I will pay attention to the PRs in the future.

neolit123
neolit123 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@neolit123
Copy link
Member

neolit123 commented Feb 14, 2019 •
edited

/assign @vishh
just a go lint fix for kubeadm that touches /hack

@SataQiu
Copy link
Member Author

SataQiu commented Feb 15, 2019

/assign @fejta

@neolit123
Copy link
Member

@SataQiu
if you have more similar changes planned that fix golint problems and touch the hack folder please send them in a single big PR. we don't want to ping the hack owners for multiple small changes.

thank you.

@SataQiu
Copy link
Member Author

SataQiu commented Feb 15, 2019

@neolit123 Thank you for your reminding! I'm sorry to bother the hack owners.

@fejta
Copy link
Contributor

fejta commented Feb 15, 2019

we don't want to ping the hack owners for multiple small changes

Thanks Lubomir for the concern here :) And SataQui thanks for cleaning up these golint failures.

FWIW I'm happy to review any PR that removes lines from the hack/.golint_failures exception list!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, neolit123, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 256106e into kubernetes:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yagonobre yagonobre yagonobre left review comments

@neolit123 neolit123 neolit123 approved these changes

@rosti rosti rosti approved these changes

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@fejta fejta

@rosti rosti

@vishh vishh

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@SataQiu @neolit123 @fejta @k8s-ci-robot @rosti @yagonobre @vishh