genericapiserver: expose openapi service to allow updating the served spec #74098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
size/S
roycaihw
changed the title
k8s-ci-robot
added
size/M
roycaihw
force-pushed
the
genericapiserver-openapi-service
branch
from
940da1e
to
49af9e5
Compare
|
/retest |
sttts
added
the
priority/important-soon
k8s-ci-robot
removed
the
needs-priority
sttts
added
the
kind/feature
k8s-ci-robot
removed
the
needs-kind
|
/retest |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roycaihw, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
I remember having a discussion with @mbohlool not wanting to do that? I may be misunderstanding. |
|
I actually wanted this but I remember a reviewer didn't want this. I don't remember what was the reason, long time ago, but I am fine with this. symbolic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expose openapi service from genericapiserver so that servers built on top of it can control/update the served spec. Needed for CRD openapi publishing
an alternative is what kube-aggregator does today: it disables genericapiserver from installing the handler, and does a custom installation itself, which is not a good pattern to follow IMO
/assign @mbohlool @sttts
Does this PR introduce a user-facing change?: