add more fields to be stripped from managedFields

[kwiesmueller]

What type of PR is this?
/kind bug

What this PR does / why we need it:
Adds more fields to get stripped from managedFields
As requested by @lavalamp in #73681

Does this PR introduce a user-facing change?:

NONE

[kwiesmueller]

/assign @lavalamp
/cc @apelisse @jennybuckley

[apelisse]

I suspect we want #74207 so we can add a test for this feature.

[kwiesmueller]

yes, I would have done it the other way round but now that you raised concerns about the MakePathOrDie, it would be more reasonable to merge #74207 first.

[kwiesmueller]

/retest

[apelisse]

I'm wondering if it'd be generally useful to know who/what has set the deletion timestamp.

[apelisse]

But it's set in the delete handler, which doesn't set the field anyway (maybe we should also fix that?). I don't know.

[kwiesmueller]

Isn't this a state from which an object cannot recover?
It might be helpful, but I thought there was the audit log feature to better track things like this?
And do we want to change the object pre deletion? Feels a little off to change managed fields on deletion as it means the user deletes a state and then we modify it before really deleting. Wouldn't expect this.

On the other hand it might be a question of consistency to add this to the delete handler.

[apelisse]

You want to see if managedFields gets removed "recursively", so you want to make this non-empty.

[lavalamp]

And do we want to change the object pre deletion? Feels a little off to change managed fields on deletion as it means the user deletes a state and then we modify it before really deleting. Wouldn't expect this.

Look at what we do for finalizers and gracePeriod. There's a whole lifecycle after a deletion is initiated...

[apelisse]

To sum-up the decision we've made: We don't know how we're going to handle deletionTimestamp in the future, we know it's not set now (because we don't track fields for DELETE). If we decided to do it later, we don't want this code to remove it, so let's ignore it for now.

[apelisse]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, kwiesmueller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiserver/pkg/endpoints/handlers/fieldmanager/OWNERS [apelisse]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment