Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendor prometheus/common/... to latest release #74248

Merged
merged 3 commits into from
Feb 25, 2019
Merged

Update vendor prometheus/common/... to latest release #74248

merged 3 commits into from
Feb 25, 2019

Conversation

danielqsj
Copy link
Contributor

What type of PR is this?

/kind flake
/sig instrumentation

What this PR does / why we need it:

update the vendor github.com/prometheus/common/... to latest release for better performance.
ref: #70926

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/flake Categorizes issue or PR as related to a flaky test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 19, 2019
@danielqsj
Copy link
Contributor Author

/cc @brancz

@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Feb 19, 2019
@mxinden mxinden mentioned this pull request Feb 19, 2019
Closed
mxinden
mxinden reviewed Feb 19, 2019
View reviewed changes
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is probably mostly used through https://github.com/prometheus/client_golang, we should how about treating it as a transient dependency of https://github.com/prometheus/client_golang? Given that client_golang introduced go modules, we could pin a specific version of prometheus/common.

What do you think @danielqsj?

@danielqsj
Copy link
Contributor Author

@mxinden agree.
After this PR merged,
the version of github.com/prometheus/client_golang is pinned as v0.9.1,
the dependency github.com/prometheus/common is pinned as v0.2.0.
Does it look good ?

@fedebongio
Copy link
Contributor

/cc @logicalhan

@danielqsj
Copy link
Contributor Author

/assign @apelisse

@mxinden
Copy link
Contributor

mxinden commented Feb 22, 2019

@danielqsj is there a particular reason why not to go with prometheus/client_golang v0.9.2, given that there are no 'CHANGE' sections in the changelog for the version?

@danielqsj
Copy link
Contributor Author

@mxinden Agree about bump prometheus/client_golang into v0.9.2. Will update it soon.

@danielqsj
Copy link
Contributor Author

@mxinden updated, PTAL

@danielqsj
Copy link
Contributor Author

/retest

@brancz
Copy link
Member

brancz commented Feb 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019
@danielqsj
Copy link
Contributor Author

ping @apelisse

mxinden
mxinden approved these changes Feb 25, 2019
View reviewed changes
Copy link
Contributor

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes @danielqsj.

@apelisse
Copy link
Member

Approving Godeps update to prometheus/client_go v0.9.2 and prometheus/common v0.2.0. No red-flag.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, danielqsj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit 1eb2acc into kubernetes:master Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden approved these changes

@apelisse apelisse Awaiting requested review from apelisse

@deads2k deads2k Awaiting requested review from deads2k

@brancz brancz Awaiting requested review from brancz

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@apelisse apelisse

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@danielqsj @fedebongio @mxinden @brancz @apelisse @k8s-ci-robot