Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vendor package github.com/hashicorp/golang-lru #74260

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Update vendor package github.com/hashicorp/golang-lru #74260

merged 1 commit into from
Feb 21, 2019

Conversation

stafot
Copy link
Contributor

@stafot stafot commented Feb 19, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Part of #69776 involves updating github.com/hashicorp/golang-lru

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

@stafot stafot mentioned this pull request Feb 19, 2019
Closed
@k8s-ci-robot
Copy link
Contributor

@stafot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @stafot. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 19, 2019
@dims
Copy link
Member

dims commented Feb 19, 2019

@stafot we are now asking for a justification for updating the dependency, can you please see the list and see what will fit here?
https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/godep.md#justifications-for-an-update

I've also updated #69776 with the same guidance

@stafot
Copy link
Contributor Author

stafot commented Feb 19, 2019

@dims Thanks, I reopened this PR based on this comment

@stafot
Copy link
Contributor Author

stafot commented Feb 19, 2019 •
edited

@dims I am not sure that it applies in any of the justifications reasons, though before this update kubernetes uses a pre-release version of hashicorp/golang-lru while with this it will use the first and also latest available release. If this doesn't justify the upgrade, feel free to close the PR.

@dims
Copy link
Member

dims commented Feb 19, 2019

/ok-to-test
/release-note-none

@stafot thanks! let's see what others say first.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 19, 2019
@dims
Copy link
Member

dims commented Feb 19, 2019

/assign @thockin @cblecker

Tim, Christoph, we were using a pre-release version of a library, this PR switches it to a released version. Is that acceptable?

@thockin
Copy link
Member

thockin commented Feb 19, 2019

This is still tagged as a pre-release (0.5.0). Do we have evidence of changes that matter to us? I'm inclined to allow this, since it's better than a random hash, but we should be pushing back on deps that are 0.x when we can.

@stafot
Copy link
Contributor Author

stafot commented Feb 19, 2019

/test pull-kubernetes-godeps

@cblecker
Copy link
Member

Test failure is legitimate. Please run hack/update-staging-godeps.sh as suggested.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 20, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 20, 2019
@cblecker
Copy link
Member

/lgtm
/approve

Yeah, I'm inclined to let this one in too, even if it's prerelease. I don't see any changes of concern.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, stafot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2019
@k8s-ci-robot k8s-ci-robot merged commit a259236 into kubernetes:master Feb 21, 2019
@stafot stafot deleted the update-vendor-dependencies branch February 21, 2019 06:23
@stafot stafot mentioned this pull request Feb 21, 2019
Closed
89 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@thockin thockin Awaiting requested review from thockin

Assignees

@cblecker cblecker

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stafot @k8s-ci-robot @dims @thockin @cblecker