Clear EndpointsLastChangeTriggerTime when there is no new trigger time to be exported #74294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should clean the EndpointsLastChangeTriggerTime annotation when there is no new trigger time to be exported. Not clearing it may result in kube-proxy exporting the wrong Network Programming Latency SLI.
k8s-ci-robot
added
kind/bug
|
/assign @wojtek-t |
k8s-ci-robot
added
sig/apps
mm4tt
changed the title
wojtek-t
added
priority/important-soon
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mm4tt, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We should clean the EndpointsLastChangeTriggerTime annotation when there is no new trigger time to be exported.
Not clearing the may result in kube-proxy exporting the wrong Network Programming Latency SLI.
An example here is when pods are being deleted, currently we're not able to compute trigger time for pod deletions (there is a TODO to tackle that).
Therefore when pods are being deleted, the trigger time doesn't change and we update an Endpoints object with the old annotation value. This results in a wrong Network Programming Latency SLI being exported in kube-proxy as we use an old EndpointsLastChangeTriggerTime value which faultly bumps the SLI up.
Below is the graph for two consecutive runs of the load test that visualizes the issue.
Does this PR introduce a user-facing change?: