Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not return error on invalid MAC address in vSphere Cloud Provider #74301

Merged
merged 1 commit into from
Feb 21, 2019
Merged

Do not return error on invalid MAC address in vSphere Cloud Provider #74301

merged 1 commit into from
Feb 21, 2019

Conversation

frapposelli
Copy link
Member

This PR fixes an erratic behavior of the vSphere Cloud Provider when running with flannel where it would return error if flannel0 interface is parsed when patching the node IP

/sig vmware
/sig cloud-provider

/kind bug

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/provider/vmware Issues or PRs related to vmware provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 20, 2019
@frapposelli
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 20, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frapposelli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 20, 2019
@frapposelli
Copy link
Member Author

/cc @sandeeppsunny

@k8s-ci-robot
Copy link
Contributor

@frapposelli: GitHub didn't allow me to request PR reviews from the following users: sandeeppsunny.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @sandeeppsunny

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frapposelli
Copy link
Member Author

/cc @andrewsykim @divyenpatel @benmoss

This covers a pretty common use case and will need to be backported like the previous patches

@andrewsykim
Copy link
Member

/priority important-soon
/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 20, 2019
@frapposelli
Copy link
Member Author

@andrewsykim I would say it's critical urgent as all the other patches have been back ported and we're pretty close to code freeze for 1.14

@andrewsykim
Copy link
Member

Makes sense!

/priority critical

@sandeeppsunny
Copy link
Contributor

Verified this fix. Node IP addresses are showing up now.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@sandeeppsunny: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

Verified this fix. Node IP addresses are showing up now.

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@frapposelli
Copy link
Member Author

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Feb 20, 2019
@frapposelli frapposelli changed the title Do not return error on ivalid MAC address in vSphere Cloud Provider Do not return error on invalid MAC address in vSphere Cloud Provider Feb 20, 2019
@frapposelli
Copy link
Member Author

/test pull-kubernetes-e2e-gce

dougm
dougm reviewed Feb 20, 2019
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@frapposelli
Copy link
Member Author

thanks all 👍

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2019
@k8s-ci-robot k8s-ci-robot merged commit d9504f1 into kubernetes:master Feb 21, 2019
@frapposelli
Copy link
Member Author

@andrewsykim can you cherry pick against 1.11 > 1.13?

This was referenced Feb 21, 2019
Merged
Merged
Merged
@andrewsykim
Copy link
Member

@frapposelli done!

#74366
#74367
#74368

k8s-ci-robot added a commit that referenced this pull request Feb 22, 2019
@k8s-ci-robot
Merge pull request #74367 from andrewsykim/automated-cherry-pick-of-#…
850c7ba 
…74301-upstream-release-1.12

Automated cherry pick of #74301: do not return error on invalid mac address in vsphere cloud
k8s-ci-robot added a commit that referenced this pull request Feb 23, 2019
@k8s-ci-robot
Merge pull request #74368 from andrewsykim/automated-cherry-pick-of-#…
ff6a78d 
…74301-upstream-release-1.13

Automated cherry pick of #74301: do not return error on invalid mac address in vsphere cloud
k8s-ci-robot added a commit that referenced this pull request Mar 4, 2019
@k8s-ci-robot
Merge pull request #74366 from andrewsykim/automated-cherry-pick-of-#…
095692f 
…74301-upstream-release-1.11

Automated cherry pick of #74301: do not return error on invalid mac address in vsphere cloud
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@erictune erictune Awaiting requested review from erictune

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@benmoss benmoss Awaiting requested review from benmoss

@divyenpatel divyenpatel Awaiting requested review from divyenpatel

Assignees

@dougm dougm

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/vmware Issues or PRs related to vmware provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frapposelli @k8s-ci-robot @andrewsykim @sandeeppsunny @dougm