Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: fix issue with missing kubeproxy fields in test data #74457

Merged
merged 1 commit into from
Feb 23, 2019

Conversation

neolit123
Copy link
Member

What this PR does / why we need it:

This patch introduced changes in kubeproxy's v1alpha1 that did were not reflected completely in our test data files for non-linux platforms:
164f79e

The change should be applied for both linux and non-linux platforms.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

/assign @bart0sh @yagonobre
please test if this works for you on OSX.

@kubernetes/sig-cluster-lifecycle-pr-reviews
/kind bug
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 23, 2019
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm labels Feb 23, 2019
@bart0sh
Copy link
Contributor

bart0sh commented Feb 23, 2019

did you test it on windows?

@neolit123
Copy link
Member Author

did you test it on windows?

no, it should just work as the field was intended for windows.

@bart0sh
Copy link
Contributor

bart0sh commented Feb 23, 2019

would make sense to test it on all platforms I guess

@neolit123
Copy link
Member Author

neolit123 commented Feb 23, 2019

@bart0sh
kubeadm does not support Windows. our unit tests are broken for a variety of reasons - just tested.
EDIT: next cycle we need to start working on this: kubernetes/kubeadm#1393

were you able to verify if this patch works on OSX?

@bart0sh
Copy link
Contributor

bart0sh commented Feb 23, 2019

yes, verified on Linux and OSX
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5312ade into kubernetes:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants