Don't fail if iface is being used by iSCSI session #74524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
bertinatto
force-pushed
the
iscsi_iface_exists
branch
from
f65742a
to
8c8fb40
Compare
|
/assign @bswartz @bertinatto, did you test it with containerized kubelet? I hope that exit codes are not lost somewhere there. |
redbaron
reviewed
Feb 26, 2019
|
I check containerized kubelet code and we execute iscsiadm in the container with kubelet, so kubelet gets authentic iscsiadm exit code, without any nsenter translation. |
|
So code-wise lgtm from me, anyone from iscsi side has has opinion? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, rootfs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rootfs
reviewed
Feb 26, 2019
bertinatto
force-pushed
the
iscsi_iface_exists
branch
from
8c8fb40
to
8b9fb04
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
bswartz
suggested changes
Feb 26, 2019
bertinatto
force-pushed
the
iscsi_iface_exists
branch
from
8b9fb04
to
df1701f
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
bertinatto
force-pushed
the
iscsi_iface_exists
branch
from
df1701f
to
d60d7e9
Compare
k8s-ci-robot
added
the
lgtm
bswartz
approved these changes
Feb 26, 2019
This was referenced Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR prevents k8s failing to create a PV if an iscsi iface already exists and is being used by a session.
Which issue(s) this PR fixes:
Fixes #74523.
Does this PR introduce a user-facing change?:
/sig storage