-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding e2e test for update and delete of resourcequota #74570
Adding e2e test for update and delete of resourcequota #74570
Conversation
Hi @s-ito-ts. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Expect(resourceQuotaResult.Spec.Hard[v1.ResourceCPU]).To(Equal(resource.MustParse("2"))) | ||
Expect(resourceQuotaResult.Spec.Hard[v1.ResourceMemory]).To(Equal(resource.MustParse("1Gi"))) | ||
|
||
By("Deleting a ResourceQuota") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liggitt Hi, just a query that can we ensure the deleted resourceQuota like we are using for secrets, configmap etc. ? For example By("Ensuring resource quota status released usage")...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand what this is asking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most part is good for me, just one comment.
|
||
By("Deleting a ResourceQuota") | ||
err = deleteResourceQuota(client, ns, quotaName) | ||
Expect(err).NotTo(HaveOccurred()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can verify the ResourceQuota is deleted by adding the following:
By("Verifying the deleted ResourceQuota")
_, err := client.CoreV1().ResourceQuotas(ns).Get(quotaName, metav1.GetOptions{})
Expect(errors.IsNotFound(err)).To(Equal(true))
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review.
I added it.
/ok-to-test |
/cc @oomichi |
Thanks for updating, /lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, s-ito-ts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This patch adds e2e test for update and delete of resourcequota to cover the following API.
Which issue(s) this PR fixes:
Fixes #74569
Special notes for your reviewer:
Does this PR introduce a user-facing change?: