Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some golint failures in pkg/registry/... #74574

Merged
merged 1 commit into from
Feb 27, 2019
Merged

fix some golint failures in pkg/registry/... #74574

merged 1 commit into from
Feb 27, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Feb 26, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Fix golint failures on :

  • pkg/registry/apps/daemonset
  • pkg/registry/apps/deployment
  • pkg/registry/apps/statefulset
  • pkg/registry/autoscaling/horizontalpodautoscaler
  • pkg/registry/batch/cronjob
  • pkg/registry/core/resourcequota
  • pkg/registry/policy/poddisruptionbudget

Which issue(s) this PR fixes:
Refs #68026

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 26, 2019
@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 26, 2019
@SataQiu SataQiu mentioned this pull request Feb 26, 2019
Closed
@SataQiu
Copy link
Member Author

SataQiu commented Feb 26, 2019

/test pull-kubernetes-e2e-gce

@SataQiu
Copy link
Member Author

SataQiu commented Feb 26, 2019

@/assign @liggitt

@liggitt
Copy link
Member

liggitt commented Feb 26, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2019
@cblecker
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Feb 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit 5ebdf3e into kubernetes:master Feb 27, 2019
@liggitt liggitt added this to the v1.14 milestone Jun 10, 2019
@liggitt liggitt removed the sig/auth Categorizes an issue or PR as relevant to SIG Auth. label Feb 18, 2020
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt liggitt left review comments

@cblecker cblecker Awaiting requested review from cblecker

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SataQiu @liggitt @k8s-ci-robot @cblecker