Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #74448: Explicitly set GVK when sending objects to webhooks #74725

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Automated cherry pick of #74448: Explicitly set GVK when sending objects to webhooks #74725

merged 1 commit into from
Mar 7, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 28, 2019

Cherry pick of #74448 on release-1.12.

#74448: Explicitly set GVK when sending objects to webhooks

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 28, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 28, 2019
@liggitt
Copy link
Member Author

liggitt commented Feb 28, 2019 •
edited

/kind bug
/sig api-machinery
/milestone v1.12
/priority important-soon

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 28, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Feb 28, 2019
@liggitt liggitt modified the milestones: v1.13, v1.12 Feb 28, 2019
@liggitt
Copy link
Member Author

liggitt commented Feb 28, 2019

/cc @feiskyer

@liggitt
Copy link
Member Author

liggitt commented Feb 28, 2019

/cc @mbohlool

@liggitt
Copy link
Member Author

liggitt commented Mar 2, 2019

/retest

@mbohlool
Copy link
Contributor

mbohlool commented Mar 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 5, 2019
@feiskyer feiskyer added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 10994c6 into kubernetes:release-1.12 Mar 7, 2019
@liggitt liggitt deleted the automated-cherry-pick-of-#74448-upstream-release-1.12 branch April 22, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@mbohlool mbohlool Awaiting requested review from mbohlool

Assignees

@mbohlool mbohlool

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liggitt @k8s-ci-robot @mbohlool @feiskyer