Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better detection of binaries for conformance image #74761

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Better detection of binaries for conformance image #74761

merged 1 commit into from
Mar 1, 2019

Conversation

dims
Copy link
Member

@dims dims commented Mar 1, 2019 •
edited

Change-Id: Id33a0827e8cb1e3369544eea3335c80c89780786

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
We need to be considerate to folks who may be trying to build this image not necessarily from a fresh checkout. currently without this change there are situations where make quick-release fails if _output/local exists but does not have the binaries.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 1, 2019
@dims dims changed the title Better detection of binaries for conformance image [WIP] Better detection of binaries for conformance image Mar 1, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2019
@k8s-ci-robot k8s-ci-robot added sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 1, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@dims
Copy link
Member Author

dims commented Mar 1, 2019

/hold
/test pull-security-kubernetes-conformance-image-test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2019
@dims
Copy link
Member Author

dims commented Mar 1, 2019

/test pull-kubernetes-conformance-image-test

@dims dims force-pushed the better-detection-of-binaries-for-conformance-image branch from 7d1c0ed to 2e148c3 Compare March 1, 2019 01:36
@dims
Copy link
Member Author

dims commented Mar 1, 2019

/test pull-kubernetes-conformance-image-test

@spiffxp
Copy link
Member

spiffxp commented Mar 1, 2019

/milestone v1.14

@k8s-ci-robot k8s-ci-robot added this to the v1.14 milestone Mar 1, 2019
@dims
Better detection of binaries for conformance image
9d7d682 
Change-Id: Id33a0827e8cb1e3369544eea3335c80c89780786
@dims dims force-pushed the better-detection-of-binaries-for-conformance-image branch from 2e148c3 to 9d7d682 Compare March 1, 2019 03:00
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2019
@dims
Copy link
Member Author

dims commented Mar 1, 2019

/test pull-kubernetes-conformance-image-test

@dims dims changed the title [WIP] Better detection of binaries for conformance image Better detection of binaries for conformance image Mar 1, 2019
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Mar 1, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 1, 2019
@dims
Copy link
Member Author

dims commented Mar 1, 2019

/release-note-none
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2019
@dims
Copy link
Member Author

dims commented Mar 1, 2019

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 1, 2019
@dims
Copy link
Member Author

dims commented Mar 1, 2019

/assign @brahmaroutu @timothysc

@dims
Copy link
Member Author

dims commented Mar 1, 2019

/area conformance

@k8s-ci-robot k8s-ci-robot added the area/conformance Issues or PRs related to kubernetes conformance tests label Mar 1, 2019
@stevesloka
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@stevesloka: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@brahmaroutu
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4bafef2 into kubernetes:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp Awaiting requested review from spiffxp

@timothysc timothysc Awaiting requested review from timothysc

Assignees

@timothysc timothysc

@brahmaroutu brahmaroutu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dims @k8s-ci-robot @spiffxp @stevesloka @brahmaroutu @timothysc