change bandwidth units from Kb to b

[mars1024]

What type of PR is this?
/kind bug

What this PR does / why we need it:
CNI bandwidth plugin is designed to use bits-per-second and bits as the units of bandwidth rates and brust, and bandwidth plugin doc has changed its bandwidth related units from Kb to b in containernetworking/plugins@220499d, and CNI CONVENTIONS has also use b as its unit in containernetworking/cni@d2be2fa. So we have to change bandwidth unit from Kb to b in kubelet/cni.

none

[k8s-ci-robot]

Hi @mars1024. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[yue9944882]

/ok-to-test

[dcbw]

To be clear, it was the 'bandwidth' CNI plugin docs that were wrong. The implementation was always in bits-per-second.

@mars1024 can you add a release note as described in the first comment? that will remove the release note required label.

[mars1024]

To be clear, it was the 'bandwidth' CNI plugin docs that were wrong. The implementation was always in bits-per-second.

@mars1024 can you add a release note as described in the first comment? that will remove the release note required label.

Sure, I will also update the pr comment.

[mars1024]

/assign @dcbw

[mars1024]

@dcbw PTAL, thx ~

[mars1024]

/assign @freehan

[mars1024]

@freehan @dcbw PTAL, thx~

[mars1024]

@freehan @dcbw friendly ping, thx ~

[thockin]

Is there actually action-required?

We should already be converting the annotation quantity into nominal units. This juts fixes a bug where we thought CNI wanted Kb but really it wanted b. As such, I do not think the release-note is right.

Otherwise it is a breaking change, and we have to have a bigger conversation.

Confirm?

[thockin]

Concretely, I think "NA" is a sufficient release note.

[freehan]

Is there any potential this will break users that depend on the wrong behavior?

I guess it will just looses the bandwidth limit, right?

[mars1024]

Is there any potential this will break users that depend on the wrong behavior?

I guess it will just looses the bandwidth limit, right?

Yes, it will just looses the bandwidth of newly created pods.

[mars1024]

Concretely, I think "NA" is a sufficient release note.

OK, just as @freehan said above, if we do not think loosing is a breaking point, we need to set release note to NA.

[mars1024]

@thockin @freehan I have set release note to NA.

[thockin]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mars1024, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/dockershim/network/OWNERS [thockin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment