-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Distroless] Convert the GCE manifests for master containers. #75624
Conversation
Hi @yuwenma. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @tallclair May I get a /ok-to-test label? |
hahahaa |
/ok-to-test |
@tallclair: GitHub didn't allow me to request PR reviews from the following users: mwwolters, dekkagaijin. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
6bc2b63
to
dd84790
Compare
/test pull-kubernetes-e2e-gce |
/retest |
/assign mwwolters |
@yuwenma: GitHub didn't allow me to assign the following users: mwwolters, dekkagaijin. Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Gentle ping, can I get a review on this @MaciekPytel @tallclair :) |
6974127
to
814f81f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MaciekPytel, yuwenma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Touched containers: kube-apiserver, kube-scheduler, kube-controller-manager. * Remove the shell dependencies when upstart the containers. * Reformat the command parameters to ["Exec", "Param1", "Param2"]
/lgtm |
Looks like this is all set :) |
/test pull-kubernetes-e2e-gce |
I just wanted to show off what your klog changes are enabling :) |
Thanks!!!! |
We need to revert that actually - this broke scalability tests in a way that we have only last 1.8GB of logs (i.e. it doesn't work with logrotate). We are blindless without logs. |
kube-controller-manager.
Test: The manifest change is tested on a real GKE cluster (GKE sandbox). Here's the Master VM
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR is a prerequisite for switching the core master containers' base image to distroless/static.(See this kep for the reasons why we want to change to distroless/static).
Basically it removes all the shell dependencies (log redirection, using shell to kick-off a kube binary file) which isn't supported by distroless.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: