Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump debian-iptables versions to v11.0.2. #75997

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Bump debian-iptables versions to v11.0.2. #75997

merged 1 commit into from
Apr 25, 2019

Conversation

grayluck
Copy link
Contributor

@grayluck grayluck commented Apr 2, 2019

What type of PR is this?
/kind bug
/priority critical-urgent
/sig release
/sig network

What this PR does / why we need it:
Follow up of #75845 to use debian-iptables:v11.0.2.

Which issue(s) this PR fixes:
Fixes #NONE

Special notes for your reviewer:
/assign @tallclair

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/network Categorizes an issue or PR as relevant to SIG Network. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @grayluck. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 2, 2019
This was referenced Apr 2, 2019
Merged
Merged
Merged
tallclair
tallclair reviewed Apr 4, 2019
View reviewed changes
build/common.sh Outdated
@@ -90,7 +90,7 @@ readonly KUBE_CONTAINER_RSYNC_PORT=8730
kube::build::get_docker_wrapped_binaries() {
local arch=$1
local debian_base_version=0.4.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.0.0?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Fixed. Thanks!

@grayluck
Copy link
Contributor Author

grayluck commented Apr 4, 2019

/assign @ixdy

@tallclair
Copy link
Member

/lgtm
/approve
/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 5, 2019
@tallclair
Copy link
Member

/approve

@grayluck
Copy link
Contributor Author

/assign @zmerlynn

@grayluck
Copy link
Contributor Author

/assign @mikedanese

@grayluck
Copy link
Contributor Author

Friendly ping. It has been cherrypicked in 1.11 and 1.12. This PR should get merged before the next cut or 1.14 will use earlier versions of iptables image than 1.11 and 1.12, which confuse people when they upgrade the cluster but images get downgraded.

@zmerlynn
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grayluck, tallclair, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2019
@grayluck
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit ffd5d1a into kubernetes:master Apr 25, 2019
@grayluck grayluck mentioned this pull request Apr 30, 2019
Merged
k8s-ci-robot added a commit that referenced this pull request May 1, 2019
@k8s-ci-robot
Merge pull request #77270 from grayluck/automated-cherry-pick-of-#759…
803a14d 
…97-upstream-release-1.14

Automated cherry pick of #75997: Bump debian-iptables versions to v11.0.2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair tallclair left review comments

@jbeda jbeda Awaiting requested review from jbeda

@lavalamp lavalamp Awaiting requested review from lavalamp

Assignees

@mikedanese mikedanese

@zmerlynn zmerlynn

@ixdy ixdy

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@grayluck @k8s-ci-robot @tallclair @zmerlynn @mikedanese @ixdy