Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump debian-iptables to v11.0.2. #75998

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Bump debian-iptables to v11.0.2. #75998

merged 1 commit into from
Apr 30, 2019

Conversation

grayluck
Copy link
Contributor

@grayluck grayluck commented Apr 2, 2019 •
edited

What type of PR is this?
/kind bug
/priority critical-urgent
/sig release
/sig network

What this PR does / why we need it:
Follow up of #75845 to use debian-iptables:v11.0.2 as a manual cherrypick of #75997 for 1.13.

Which issue(s) this PR fixes:
Fixes #NONE

Special notes for your reviewer:
/assign @tallclair

Does this PR introduce a user-facing change?:

None

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 2, 2019
@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/network Categorizes an issue or PR as relevant to SIG Network. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @grayluck. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tpepper
Copy link
Member

tpepper commented Apr 4, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 4, 2019
@tallclair
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2019
@grayluck
Copy link
Contributor Author

grayluck commented Apr 4, 2019

/assign @ixdy

@grayluck
Copy link
Contributor Author

/assign @aleksandra-malinowska @tpepper

@tpepper
Copy link
Member

tpepper commented Apr 12, 2019

@grayluck you're still needing an approver from build/OWNERS as per #75998 (comment)

@zmerlynn
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grayluck, tallclair, zmerlynn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2019
@grayluck
Copy link
Contributor Author

@tpepper I've got approval from build owner. It's waiting for your cherrypick approval. Thanks.

@spiffxp
Copy link
Member

spiffxp commented Apr 19, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from spiffxp April 19, 2019 22:51
@grayluck
Copy link
Contributor Author

Friendly ping. It has been cherrypicked in 1.11 and 1.12. This PR should get merged before the next cut or 1.13 will use earlier versions of iptables image than 1.11 and 1.12, which confuse people when they upgrade the cluster but images get downgraded. Thanks!

@justaugustus justaugustus added this to Backlog in SIG Release Apr 28, 2019
@justaugustus justaugustus moved this from Backlog to To do in SIG Release Apr 28, 2019
@aleksandra-malinowska aleksandra-malinowska added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 30, 2019
@aleksandra-malinowska
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit fd686f1 into kubernetes:release-1.13 Apr 30, 2019
SIG Release automation moved this from To do to Done Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmerlynn zmerlynn Awaiting requested review from zmerlynn

Assignees

@tpepper tpepper

@aleksandra-malinowska aleksandra-malinowska

@ixdy ixdy

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@grayluck @k8s-ci-robot @tpepper @tallclair @zmerlynn @spiffxp @aleksandra-malinowska @ixdy