Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #75750: Improve volume operation metrics #76222

Merged
merged 2 commits into from
May 2, 2019
Merged

Automated cherry pick of #75750: Improve volume operation metrics #76222

merged 2 commits into from
May 2, 2019

Conversation

msau42
Copy link
Member

@msau42 msau42 commented Apr 6, 2019 •
edited

Cherry pick of #75750 on release-1.14.

#75750: Improve volume operation metrics

Adds a new "storage_operation_status_count" metric for kube-controller-manager and kubelet to count success and error statues.

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 6, 2019
@k8s-ci-robot k8s-ci-robot added area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2019
@msau42
Copy link
Member Author

msau42 commented Apr 6, 2019

/kind cleanup
/priority important-soon
/sig storage

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 6, 2019
@msau42
Copy link
Member Author

msau42 commented Apr 16, 2019

/assign @gnufied

@gnufied
Copy link
Member

gnufied commented Apr 23, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
@msau42
Copy link
Member Author

msau42 commented Apr 30, 2019

/assign @aleksandra-malinowska

@tpepper
Copy link
Member

tpepper commented Apr 30, 2019

@msau42 can you update the release note?

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Apr 30, 2019
@msau42
Copy link
Member Author

msau42 commented Apr 30, 2019

added

@msau42
Copy link
Member Author

msau42 commented Apr 30, 2019

on a side note, is the tooling supposed to automatically take the release note from the parent pr?

@tpepper
Copy link
Member

tpepper commented May 2, 2019

on a side note, is the tooling supposed to automatically take the release note from the parent pr?

It is supposed to and does, but sometimes it gets confused. I'm not seeing why it should have failed on this one.

@tpepper tpepper added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 2, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8ffc4b2 into kubernetes:release-1.14 May 2, 2019
@msau42 msau42 deleted the automated-cherry-pick-of-#75750-upstream-release-1.14 branch October 19, 2019 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@rootfs rootfs Awaiting requested review from rootfs

Assignees

@gnufied gnufied

@aleksandra-malinowska aleksandra-malinowska

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@msau42 @k8s-ci-robot @gnufied @tpepper @aleksandra-malinowska