Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some varibles and clean up codes in scheduler_binder.go #76333

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Rename some varibles and clean up codes in scheduler_binder.go #76333

merged 1 commit into from
Apr 20, 2019

Conversation

cwdsuzhou
Copy link
Member

@cwdsuzhou cwdsuzhou commented Apr 9, 2019 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

I read the codes in scheduler_binder.go. I found some variable may misleading. So, rename some variables and clean up codes in scheduler_binder.go.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @cwdsuzhou. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 9, 2019
@cwdsuzhou
Copy link
Member Author

/assign @msau42

@cwdsuzhou
Copy link
Member Author

@jsafrane @lichuqiang @msau42

PTAL

msau42
msau42 reviewed Apr 12, 2019
View reviewed changes
pkg/controller/volume/persistentvolume/scheduler_binder.go
@@ -160,26 +160,26 @@ func (b *volumeBinder) FindPodVolumes(pod *v1.Pod, node *v1.Node) (unboundVolume
}()

var (
matchedClaims []*bindingInfo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer matchedClaims because it's more obvious that FindPodVolumes found matching PVs for them.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, however matchedClaim may be misleading, it may cause users consider it as a pvc

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about naming it "matchedBindings" then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done! seems better!

@msau42
Copy link
Member

msau42 commented Apr 12, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2019
@cwdsuzhou
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@cwdsuzhou
Copy link
Member Author

/test pull-kubernetes-e2e-gce-100-performance
/test pull-kubernetes-kubemark-e2e-gce-big

@cwdsuzhou
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

2 similar comments
@cwdsuzhou
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@cwdsuzhou
Copy link
Member Author

/test pull-kubernetes-kubemark-e2e-gce-big

@cwdsuzhou
Copy link
Member Author

ping @msau42

@msau42
Copy link
Member

msau42 commented Apr 19, 2019

/lgtm
/approve
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cwdsuzhou, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 22c67bb into kubernetes:master Apr 20, 2019
@cofyc cofyc mentioned this pull request Apr 22, 2019
Merged
3 tasks
@wojtek-t wojtek-t mentioned this pull request Apr 27, 2019
Closed
@cwdsuzhou cwdsuzhou mentioned this pull request May 3, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@jsafrane jsafrane Awaiting requested review from jsafrane

@lichuqiang lichuqiang Awaiting requested review from lichuqiang

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cwdsuzhou @k8s-ci-robot @msau42