Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential test flakes in HPA tests TestEventNotCreated and TestAvoidUncessaryUpdates #76455

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Fix potential test flakes in HPA tests TestEventNotCreated and TestAvoidUncessaryUpdates #76455

merged 1 commit into from
Apr 18, 2019

Conversation

joelsmith
Copy link
Contributor

@joelsmith joelsmith commented Apr 11, 2019 •
edited

What type of PR is this?
/kind flake

What this PR does / why we need it:
Fixes a potential deadlock in TestEventNotCreated which causes the test to time out and fail.

Also fixes potential correctness issue in TestAvoidUncessaryUpdates where test data was written without holding the lock.

Which issue(s) this PR fixes:
Fixes #76454

Special notes for your reviewer:
This one might be easier to review by adding ?w=1 to the files URL to have GitHub's diff ignore whitespace, like this.
Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 11, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 11, 2019
@joelsmith joelsmith mentioned this pull request Apr 11, 2019
Closed
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2019
@joelsmith joelsmith mentioned this pull request Apr 11, 2019
Merged
@joelsmith
Copy link
Contributor Author

Looks like the test infra failed to spin up
/test pull-kubernetes-kubemark-e2e-gce-big

@joelsmith
Copy link
Contributor Author

Looks like they have fixed the test
/test pull-kubernetes-kubemark-e2e-gce-big

@joelsmith
Copy link
Contributor Author

@mwielgus PTAL when you have a moment
/assign @mwielgus

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2019
@joelsmith
Fix potential test flakes in HPA tests TestEventNotCreated and TestAv…
f50696a 
…oidUncessaryUpdates

Also, re-work the code so that the lock is never held while writing to the chan
@joelsmith joelsmith mentioned this pull request Apr 17, 2019
Merged
@josephburnett
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

@josephburnett: changing LGTM is restricted to assignees, and only kubernetes/kubernetes repo collaborators may be assigned issues.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@josephburnett
Copy link
Member

@mwielgus please lgtm and approve this pr. Thanks!

@joelsmith
Copy link
Contributor Author

/assign @josephburnett

@k8s-ci-robot
Copy link
Contributor

@joelsmith: GitHub didn't allow me to assign the following users: josephburnett.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @josephburnett

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mwielgus
mwielgus approved these changes Apr 18, 2019
View reviewed changes
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelsmith, josephburnett, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0772f85 into kubernetes:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephburnett josephburnett josephburnett left review comments

@mwielgus mwielgus mwielgus approved these changes

@fgrzadkowski fgrzadkowski Awaiting requested review from fgrzadkowski

@piosz piosz Awaiting requested review from piosz

Assignees

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deadlock causes flake in Horizontal Pod Autoscaler unit tests
4 participants
@joelsmith @josephburnett @k8s-ci-robot @mwielgus