Add DataSource to PVC describe #76463

j-griffith · 2019-04-11T20:22:29Z

/kind bug

What this PR does / why we need it:
This change adds non nil DataSource entries of a PVC to the describe pvc output. Currently there's no real way to know for sure if you submitted an invalid or unsupported DataSource Kind if it was accepted or not.

For example, using the Hostpath driver, I can enter any info I want as DataSource Kind and Name and the volume is succesfully created/bound. Of course the info I supplied is filtered out, but I don't have any way of knowing that via the API.

In the case of valid entries (ie VolumeSnapshot and a supporting CSI Plugin) again there's no information after creation to make it clear to me that the PVC was in fact valid and created with the DataSource that I specified.

Which issue(s) this PR fixes:

Fixes #76460

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Non nil DataSource entries on PVC's are now displayed as part of `describe pvc` output.

j-griffith · 2019-04-11T20:23:02Z

/sig storage

msau42 · 2019-04-17T17:13:37Z

/hold
until datasource is beta

fejta-bot · 2019-07-16T17:14:24Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

msau42 · 2019-07-16T22:39:00Z

/remove-lifecycle stale

msau42 · 2019-07-16T22:39:15Z

/hold cancel
targeting beta in 1.16

msau42 · 2019-07-16T22:40:09Z

pkg/kubectl/describe/versioned/describe.go

@@ -1519,6 +1519,11 @@ func describePersistentVolumeClaim(pvc *corev1.PersistentVolumeClaim, events *co
 		if pvc.Spec.VolumeMode != nil {
 			w.Write(LEVEL_0, "VolumeMode:\t%v\n", *pvc.Spec.VolumeMode)
 		}
+		if pvc.Spec.DataSource != nil {


can we add a unit test for this?

Yup, added!

j-griffith · 2019-07-17T13:33:30Z

/retest

msau42 · 2019-07-17T18:32:14Z

/lgtm
/assign @mengqiy
/retest

j-griffith · 2019-08-10T14:37:58Z

same changes, rebased to the move to staging

j-griffith · 2019-08-10T16:50:35Z

/retest

j-griffith · 2019-08-10T17:22:13Z

/kind bug

msau42 · 2019-08-12T18:33:09Z

/lgtm

mengqiy

/lgtm
/approve

k8s-ci-robot · 2019-08-12T21:10:44Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: j-griffith, mengqiy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~staging/src/k8s.io/kubectl/OWNERS~~ [mengqiy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

j-griffith · 2019-08-12T22:05:21Z

/retestt

fejta-bot · 2019-08-13T01:59:23Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2019-08-13T07:14:23Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2019-08-13T13:32:24Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

fejta-bot · 2019-08-13T16:41:25Z

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

cwdsuzhou · 2019-09-06T06:07:33Z

staging/src/k8s.io/kubectl/pkg/describe/versioned/describe.go

@@ -1534,6 +1534,11 @@ func describePersistentVolumeClaim(pvc *corev1.PersistentVolumeClaim, events *co
 		if pvc.Spec.VolumeMode != nil {
 			w.Write(LEVEL_0, "VolumeMode:\t%v\n", *pvc.Spec.VolumeMode)
 		}
+		if pvc.Spec.DataSource != nil {
+			w.Write(LEVEL_0, "DataSource:\n")
+			w.Write(LEVEL_1, "Name:\t%v\n", pvc.Spec.DataSource.Name)


I am confused why not print pvc.Spec.DataSource.APIGroup at the same time

Yes, I think printing out api group makes sense too. Can you open a PR to add it? Right now, since only cloning is beta and on by default, then this can only be PVC type.

Yes, I think printing out api group makes sense too. Can you open a PR to add it? Right now, since only cloning is beta and on by default, then this can only be PVC type.

Sure, I will open a pr.

…_pvc_describe Add DataSource to PVC describe Kubernetes-commit: 9dad928

k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 11, 2019

k8s-ci-robot requested review from juanvallejo and mengqiy April 11, 2019 20:23

k8s-ci-robot added area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. labels Apr 11, 2019

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2019

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 16, 2019

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 16, 2019

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 16, 2019

msau42 reviewed Jul 16, 2019

View reviewed changes

j-griffith force-pushed the add_datasource_to_pvc_describe branch from 403f70e to a21a410 Compare July 17, 2019 04:23

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2019

k8s-ci-robot assigned mengqiy and msau42 Jul 17, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2019

Add DataSource to PVC describe

5cc2ea7

j-griffith force-pushed the add_datasource_to_pvc_describe branch from a21a410 to 5cc2ea7 Compare August 10, 2019 14:36

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 10, 2019

k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Aug 10, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 12, 2019

mengqiy approved these changes Aug 12, 2019

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2019

k8s-ci-robot merged commit 9dad928 into kubernetes:master Aug 13, 2019

k8s-ci-robot added this to the v1.16 milestone Aug 13, 2019

cwdsuzhou reviewed Sep 6, 2019

View reviewed changes

cwdsuzhou mentioned this pull request Sep 8, 2019

Add apigroup to the data source of pvc description #82464

Merged

wking pushed a commit to wking/kubernetes that referenced this pull request Jul 21, 2020

Merge pull request kubernetes#76463 from j-griffith/add_datasource_to…

03b9054

…_pvc_describe Add DataSource to PVC describe Kubernetes-commit: 9dad928

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DataSource to PVC describe #76463

Add DataSource to PVC describe #76463

j-griffith commented Apr 11, 2019 •

edited

j-griffith commented Apr 11, 2019

msau42 commented Apr 17, 2019

fejta-bot commented Jul 16, 2019

msau42 commented Jul 16, 2019

msau42 commented Jul 16, 2019

msau42 Jul 16, 2019

j-griffith Jul 17, 2019

j-griffith commented Jul 17, 2019

msau42 commented Jul 17, 2019

j-griffith commented Aug 10, 2019

j-griffith commented Aug 10, 2019

j-griffith commented Aug 10, 2019

msau42 commented Aug 12, 2019

mengqiy left a comment

k8s-ci-robot commented Aug 12, 2019

j-griffith commented Aug 12, 2019

fejta-bot commented Aug 13, 2019

fejta-bot commented Aug 13, 2019

fejta-bot commented Aug 13, 2019

fejta-bot commented Aug 13, 2019

cwdsuzhou Sep 6, 2019

msau42 Sep 6, 2019

cwdsuzhou Sep 8, 2019

Add DataSource to PVC describe #76463

Add DataSource to PVC describe #76463

Conversation

j-griffith commented Apr 11, 2019 • edited

j-griffith commented Apr 11, 2019

msau42 commented Apr 17, 2019

fejta-bot commented Jul 16, 2019

msau42 commented Jul 16, 2019

msau42 commented Jul 16, 2019

msau42 Jul 16, 2019

Choose a reason for hiding this comment

j-griffith Jul 17, 2019

Choose a reason for hiding this comment

j-griffith commented Jul 17, 2019

msau42 commented Jul 17, 2019

j-griffith commented Aug 10, 2019

j-griffith commented Aug 10, 2019

j-griffith commented Aug 10, 2019

msau42 commented Aug 12, 2019

mengqiy left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Aug 12, 2019

j-griffith commented Aug 12, 2019

fejta-bot commented Aug 13, 2019

fejta-bot commented Aug 13, 2019

fejta-bot commented Aug 13, 2019

fejta-bot commented Aug 13, 2019

cwdsuzhou Sep 6, 2019

Choose a reason for hiding this comment

msau42 Sep 6, 2019

Choose a reason for hiding this comment

cwdsuzhou Sep 8, 2019

Choose a reason for hiding this comment

j-griffith commented Apr 11, 2019 •

edited