Fix golint failures of e2e/framework/util.go - part2 #76488

atoato88 · 2019-04-12T05:40:52Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This is a part of a series for fixing golint failures for util.go.

fixes golint failures from line 1395 to line 2353 at original util.go

This fixes golint failures of the following file:

test/e2e/framework/util.go

This changes following files because of change function name
in above file.

test/e2e/apps/rc.go
test/e2e/apps/replica_set.go

Special notes for your reviewer:

The others of this series are following:

part1: Fix golint failures of e2e/framework/util.go - part1 #76348

Does this PR introduce a user-facing change?:

NONE

Ref: #68026

k8s-ci-robot · 2019-04-12T05:41:00Z

Hi @atoato88. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

xichengliudui · 2019-04-12T07:33:30Z

/ok-to-test

xichengliudui · 2019-04-12T07:35:53Z

/priority backlog

xichengliudui · 2019-04-12T07:38:23Z

/lgtm

SataQiu · 2019-04-12T08:53:01Z

test/e2e/framework/util.go

@@ -1515,7 +1516,7 @@ func podRunning(c clientset.Interface, podName, namespace string) wait.Condition
 	}
 }

-// WaitTimeoutForPodEvent waits for an event to occur for a pod
+// WaitTimeoutForPodEvent waits for an event to occur for a pod.


added some minor comments.

Suggested change

// WaitTimeoutForPodEvent waits for an event to occur for a pod.

// WaitTimeoutForPodEvent waits the given timeout duration for a pod event to occur.

Thank you for comment.
I've fixed this.

SataQiu · 2019-04-12T08:56:32Z

test/e2e/framework/util.go

@@ -1856,13 +1859,14 @@ type podProxyResponseChecker struct {
 	pods           *v1.PodList
 }

-func PodProxyResponseChecker(c clientset.Interface, ns string, label labels.Selector, controllerName string, respondName bool, pods *v1.PodList) podProxyResponseChecker {
-	return podProxyResponseChecker{c, ns, label, controllerName, respondName, pods}
+// GetPodProxyResponseChecker returns a context for checking a pods responses.


Is there a grammatical problem here?

Suggested change

// GetPodProxyResponseChecker returns a context for checking a pods responses.

// GetPodProxyResponseChecker returns a context for checking pods responses.

SataQiu · 2019-04-12T09:08:20Z

test/e2e/framework/util.go

@@ -2098,6 +2109,7 @@ func ServiceResponding(c clientset.Interface, ns, name string) error {
 	})
 }

+// RestclientConfig returns a config holds the information needed to build connect to kubernetes clusters.


Suggested change

// RestclientConfig returns a config holds the information needed to build connect to kubernetes clusters.

// RestclientConfig returns a config holds the information needed to build connection to kubernetes clusters.

andrewsykim · 2019-04-12T17:03:26Z

test/e2e/framework/util.go

-func PodProxyResponseChecker(c clientset.Interface, ns string, label labels.Selector, controllerName string, respondName bool, pods *v1.PodList) podProxyResponseChecker {
-	return podProxyResponseChecker{c, ns, label, controllerName, respondName, pods}
+// GetPodProxyResponseChecker returns a context for checking pods responses.
+func GetPodProxyResponseChecker(c clientset.Interface, ns string, label labels.Selector, controllerName string, respondName bool, pods *v1.PodList) PodProxyResponseChecker {


Is prepending this method with Get something that golint enforces?

Looks like this is a constructor method, what are your thoughts on NewPodProxyResponseChecker instead?

This renaming seems for avoiding duplicated names between struct name (PodProxyResponseChecker which is returned with this method) and this method name.
NewPodProxyResponseChecker is also a good option for us I feel.

andrewsykim · 2019-04-12T17:09:36Z

test/e2e/framework/util.go

-func NewKubectlCommand(args ...string) *kubectlBuilder {
-	b := new(kubectlBuilder)
+// GetNewKubectlCommand returns a KubectlBuilder for running kubectl.
+func GetNewKubectlCommand(args ...string) *KubectlBuilder {


I liked NewKubectlCommand actually, was golint complaining about this?

Thank you for comment.
I've fixed this.

atoato88 · 2019-04-17T09:54:37Z

I rebased with current master(commit: b359b6b).

This is a part of a series for fixing golint failures for util.go. - fixes golint failures from line 1395 to line 2353 at original util.go This fixes golint failures of the following file: - test/e2e/framework/util.go This changes following files because of change function name in above file. - test/e2e/apps/rc.go - test/e2e/apps/replica_set.go

oomichi

Thanks for updating

/lgtm

oomichi · 2019-04-23T18:01:35Z

/approve

timothysc

/lgtm
/approve

k8s-ci-robot · 2019-04-23T18:22:25Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88, oomichi, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/e2e/apps/OWNERS~~ [timothysc]
~~test/e2e/framework/OWNERS~~ [oomichi,timothysc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2019

k8s-ci-robot requested review from andrewsykim and erictune April 12, 2019 05:41

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 12, 2019

k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 12, 2019

k8s-ci-robot assigned xichengliudui Apr 12, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2019

SataQiu reviewed Apr 12, 2019

View reviewed changes

atoato88 force-pushed the fix-golint-e2e-framework-util-go-part2 branch from 1eee2d6 to c2346c9 Compare April 12, 2019 14:48

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 12, 2019

andrewsykim reviewed Apr 12, 2019

View reviewed changes

atoato88 force-pushed the fix-golint-e2e-framework-util-go-part2 branch from c2346c9 to 0a56fe4 Compare April 17, 2019 09:51

atoato88 force-pushed the fix-golint-e2e-framework-util-go-part2 branch from 0a56fe4 to 85f21c1 Compare April 17, 2019 10:01

atoato88 mentioned this pull request Apr 17, 2019

Fix golint failures of e2e/framework/util.go - part3 #76705

Merged

oomichi reviewed Apr 17, 2019

View reviewed changes

k8s-ci-robot assigned oomichi Apr 17, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019

atoato88 mentioned this pull request Apr 18, 2019

Fix golint failures of e2e/framework/util.go - part4 #76745

Merged

timothysc approved these changes Apr 23, 2019

View reviewed changes

k8s-ci-robot assigned timothysc Apr 23, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019

k8s-ci-robot merged commit 4098347 into kubernetes:master Apr 23, 2019

atoato88 mentioned this pull request Apr 26, 2019

REQUEST: New membership for atoato88 kubernetes/org#771

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix golint failures of e2e/framework/util.go - part2 #76488

Fix golint failures of e2e/framework/util.go - part2 #76488

atoato88 commented Apr 12, 2019 •

edited

k8s-ci-robot commented Apr 12, 2019

xichengliudui commented Apr 12, 2019

xichengliudui commented Apr 12, 2019

xichengliudui commented Apr 12, 2019

SataQiu Apr 12, 2019

atoato88 Apr 12, 2019

SataQiu Apr 12, 2019

atoato88 Apr 12, 2019

SataQiu Apr 12, 2019

atoato88 Apr 12, 2019

andrewsykim Apr 12, 2019

andrewsykim Apr 12, 2019

oomichi Apr 12, 2019

atoato88 Apr 17, 2019

andrewsykim Apr 12, 2019

atoato88 Apr 17, 2019

atoato88 commented Apr 17, 2019

oomichi left a comment

oomichi commented Apr 23, 2019

timothysc left a comment

k8s-ci-robot commented Apr 23, 2019

	// WaitTimeoutForPodEvent waits for an event to occur for a pod.
	// WaitTimeoutForPodEvent waits the given timeout duration for a pod event to occur.

	// GetPodProxyResponseChecker returns a context for checking a pods responses.
	// GetPodProxyResponseChecker returns a context for checking pods responses.

	// RestclientConfig returns a config holds the information needed to build connect to kubernetes clusters.
	// RestclientConfig returns a config holds the information needed to build connection to kubernetes clusters.

Fix golint failures of e2e/framework/util.go - part2 #76488

Fix golint failures of e2e/framework/util.go - part2 #76488

Conversation

atoato88 commented Apr 12, 2019 • edited

k8s-ci-robot commented Apr 12, 2019

xichengliudui commented Apr 12, 2019

xichengliudui commented Apr 12, 2019

xichengliudui commented Apr 12, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atoato88 commented Apr 17, 2019

oomichi left a comment

Choose a reason for hiding this comment

oomichi commented Apr 23, 2019

timothysc left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 23, 2019

atoato88 commented Apr 12, 2019 •

edited