Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: agnhost image updates #76507

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

claudiubelu
Copy link
Contributor

@claudiubelu claudiubelu commented Apr 12, 2019

What type of PR is this?

/kind failing-test
/kind feature

/sig testing
/sig windows

What this PR does / why we need it:

Adds the following subcommands to the agnhost binary:

  • dns-server-list: outputs the host's DNS server list with which it was
    configured with. This can be found in /etc/resolv.conf on Linux and
    through some powershell commands on Windows.
  • etc-hosts: outputs the host's hosts file. This can be found in /etc/hosts
    for Linux, and C:/Windows/System32/drivers/etc/hosts for Windows.
  • pause: pauses the binary's execution. This can be used to keep the Pod in
    a Running state for various reasons, including executing additional agnhost
    commands.

Refactors bits of the code to avoid duplication.

Adds a README for the agnhost image.

Which issue(s) this PR fixes:

Related #73425
Related #74985
Needed by: 76508

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. kind/feature Categorizes issue or PR as related to a new feature. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 12, 2019
test/images/agnhost/README.md Outdated Show resolved Hide resolved
test/images/agnhost/README.md Outdated Show resolved Hide resolved
test/images/agnhost/README.md Show resolved Hide resolved
@neolit123
Copy link
Member

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 13, 2019
Adds the following subcommands to the agnhost binary:

- dns-server-list: outputs the host's DNS server list with which it was
  configured with. This can be found in /etc/resolv.conf on Linux and
  through some powershell commands on Windows.
- etc-hosts: outputs the host's hosts file. This can be found in /etc/hosts
  for Linux, and C:/Windows/System32/drivers/etc/hosts for Windows.
- pause: pauses the binary's execution. This can be used to keep the Pod in
  a Running state for various reasons, including executing additional agnhost
  commands.

Refactors bits of the code to avoid duplication.

Adds a README for the agnhost image.
@claudiubelu claudiubelu force-pushed the tests/agnhost-updates branch 2 times, most recently from 52485ba to 60e9fe7 Compare April 15, 2019 13:44
@spiffxp
Copy link
Member

spiffxp commented Apr 30, 2019

/approve
I leave the /lgtm to @neolit123

Ping #sig-testing once this has merged to ensure a new image is built using these changes

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bclau, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
@neolit123
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit afde45a into kubernetes:master Apr 30, 2019
@claudiubelu claudiubelu deleted the tests/agnhost-updates branch May 6, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants