Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update the output of install-etcd.sh, show how to export the environment of etcd #76608

Merged
merged 1 commit into from
Apr 20, 2019

Conversation

suigh
Copy link
Contributor

@suigh suigh commented Apr 15, 2019

What type of PR is this?
/kind flake
/sig cli

What this PR does / why we need it:
To start a local/fake cluster, what we need to do is run "hack/install-etcd.sh" first and then run "hack/local-up-cluster.sh".

If the "install-etcd.sh" is executed before, what we get is like:
etcd v3.3.10 already installed at path:
/opt/src/k8s.io/kubernetes/third_party/etcd-v3.3.10-linux-amd64

This information is not enough/convenient to run "local-up-cluster.sh" again as user needs to set the the etcd information into environment variable PATH before running this command. The current output is not user friendly to a new kubernetes user (like me).

To fix this issue, the new message will be as following when the etcd is already installed:
etcd v3.3.10 already installed. To use:
export PATH=/opt/src/k8s.io/kubernetes/third_party/etcd:${PATH}

Which issue(s) this PR fixes:
Fixes # NONE

Does this PR introduce a user-facing change?:
NONE

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/flake Categorizes issue or PR as related to a flaky test. sig/cli Categorizes an issue or PR as relevant to SIG CLI. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @suigh. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@suigh suigh changed the title update script enhance the output of install-etcd.sh Apr 15, 2019
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/release-note-none
/ok-to-test
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 15, 2019
@neolit123
Copy link
Member

thanks for the PR @suigh
/assign @dims

@neolit123
Copy link
Member

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 15, 2019
@dims
Copy link
Member

dims commented Apr 15, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 15, 2019
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

hack/lib/etcd.sh Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2019
@dims
Copy link
Member

dims commented Apr 15, 2019

/hold

for @cblecker 's comments

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 16, 2019
@cblecker
Copy link
Member

/test all

@cblecker
Copy link
Member

/retest

@cblecker
Copy link
Member

@suigh Things look good! Last step: can you please squash your commits, and update your commit message to be descriptive of the change?

Thanks!

@suigh
Copy link
Contributor Author

suigh commented Apr 19, 2019

@cblecker thanks for your suggestion. Update/merge the commit message to
"update the output of install-etcd.sh, show how to export the environment of etcd."

@suigh Things look good! Last step: can you please squash your commits, and update your commit message to be descriptive of the change?

Thanks!

@suigh suigh changed the title enhance the output of install-etcd.sh update the output of install-etcd.sh, show how to export the environment of etcd Apr 19, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2019
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, dims, suigh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f980370 into kubernetes:master Apr 20, 2019
@suigh suigh deleted the b1_etcd.sh branch April 22, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/flake Categorizes issue or PR as related to a flaky test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants