-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update the output of install-etcd.sh, show how to export the environment of etcd #76608
Conversation
Hi @suigh. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/release-note-none
/ok-to-test
/priority backlog
/release-note-none |
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/hold
/hold for @cblecker 's comments |
/test all |
/retest |
@suigh Things look good! Last step: can you please squash your commits, and update your commit message to be descriptive of the change? Thanks! |
@cblecker thanks for your suggestion. Update/merge the commit message to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cblecker, dims, suigh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind flake
/sig cli
What this PR does / why we need it:
To start a local/fake cluster, what we need to do is run "hack/install-etcd.sh" first and then run "hack/local-up-cluster.sh".
If the "install-etcd.sh" is executed before, what we get is like:
etcd v3.3.10 already installed at path:
/opt/src/k8s.io/kubernetes/third_party/etcd-v3.3.10-linux-amd64
This information is not enough/convenient to run "local-up-cluster.sh" again as user needs to set the the etcd information into environment variable PATH before running this command. The current output is not user friendly to a new kubernetes user (like me).
To fix this issue, the new message will be as following when the etcd is already installed:
etcd v3.3.10 already installed. To use:
export PATH=/opt/src/k8s.io/kubernetes/third_party/etcd:${PATH}
Which issue(s) this PR fixes:
Fixes # NONE
Does this PR introduce a user-facing change?:
NONE