Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable conformance requirement check #76622

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Enable conformance requirement check #76622

merged 1 commit into from
Apr 17, 2019

Conversation

oomichi
Copy link
Member

@oomichi oomichi commented Apr 15, 2019 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

This enables conformance test check for the requirements.

Ref: #74432

Local test 1: Success case:

$ make verify WHAT=conformance-requirements
Verifying verify-conformance-requirements.sh

+++ Running case: verify.conformance-requirements
+++ working dir: /home/oomichi/go/src/k8s.io/kubernetes
+++ command: bash "hack/make-rules/../../hack/verify-conformance-requirements.sh"
Congratulations!  All e2e test source files have been linted for conformance requirements.
+++ exit code: 0
SUCCESS  verify-conformance-requirements.sh     0s

Local test 2: Failure case:

$ make verify WHAT=conformance-requirements
Verifying verify-conformance-requirements.sh

+++ Running case: verify.conformance-requirements
+++ working dir: /home/oomichi/go/src/k8s.io/kubernetes
+++ command: bash "hack/make-rules/../../hack/verify-conformance-requirements.sh"
/home/oomichi/go/src/k8s.io/kubernetes/test/e2e//kubectl/kubectl.go: Conformance test should not call SkipIfProviderIs()/SkipUnlessProviderIs()
Error: We need to fix the above errors.
exit status 1
+++ exit code: 1
+++ error: 1
FAILED   verify-conformance-requirements.sh     1s
========================
FAILED TESTS
========================
hack/make-rules/../../hack/verify-conformance-requirements.sh
Makefile:128: recipe for target 'verify' failed
make: *** [verify] Error 1

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 15, 2019
@cblecker
Copy link
Member

/hold

I'm not 100% sure that the place for this is directly in the existing golint script:

  • Will the output always be in the same format as golint?
  • Would the failures list apply in the same way? Do we even want to provide a mechanism to ignore conformance lints?
  • It's a bit disingenuous as it's not actually golint failing, it's our own linter.

Would a separate verify script be better?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2019
neolit123
neolit123 reviewed Apr 15, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @oomichi 🎉
/lgtm
/kind feature
/priority important-longterm
/assign @timothysc

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 15, 2019
@neolit123
Copy link
Member

neolit123 commented Apr 15, 2019 •
edited

oh, hack/verify-golint.sh might not be the right place indeed. completely missed the file.

Would a separate verify script be better?

+1

@neolit123
Copy link
Member

/sig testing

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 15, 2019
@cblecker
Copy link
Member

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 15, 2019
@timothysc timothysc added the area/conformance Issues or PRs related to kubernetes conformance tests label Apr 15, 2019
@timothysc timothysc added this to To Triage in conformance-definition via automation Apr 15, 2019
@oomichi
Copy link
Member Author

oomichi commented Apr 15, 2019

OK, let's add separated script.

@oomichi oomichi changed the title Enable conformance requirement check WIP: Enable conformance requirement check Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2019
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 15, 2019
@oomichi oomichi changed the title WIP: Enable conformance requirement check Enable conformance requirement check Apr 15, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2019
cblecker
cblecker reviewed Apr 16, 2019
View reviewed changes
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also review and correct the shellcheck errors.

hack/verify-conformance-requirements.sh Outdated Show resolved Hide resolved
@oomichi oomichi changed the title Enable conformance requirement check WIP: Enable conformance requirement check Apr 16, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2019
@oomichi oomichi changed the title WIP: Enable conformance requirement check Enable conformance requirement check Apr 16, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2019
@oomichi
Copy link
Member Author

oomichi commented Apr 16, 2019

@cblecker Thank you so much for your comments, now this becomes green I feel.

@spiffxp
Copy link
Member

spiffxp commented Apr 16, 2019

/approve
but I'm withholding my own /lgtm pending an answer on the use of false

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oomichi, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@oomichi oomichi mentioned this pull request Apr 16, 2019
Merged
@oomichi
Copy link
Member Author

oomichi commented Apr 17, 2019

/test pull-kubernetes-e2e-gce

@spiffxp
Copy link
Member

spiffxp commented Apr 17, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@oomichi
Copy link
Member Author

oomichi commented Apr 17, 2019

This seems to work fine as https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/76622/pull-kubernetes-verify/1118286688490098688

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 401cc19 into kubernetes:master Apr 17, 2019
conformance-definition automation moved this from To Triage to Done Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spiffxp spiffxp spiffxp left review comments

@neolit123 neolit123 neolit123 left review comments

@cblecker cblecker cblecker left review comments

Assignees

@spiffxp spiffxp

@timothysc timothysc

@neolit123 neolit123

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
conformance-definition
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@oomichi @cblecker @neolit123 @spiffxp @k8s-ci-robot @timothysc