Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates OWNERS files and OWNERS_ALIASES for SIG Apps #76669

Merged
merged 1 commit into from Apr 17, 2019

Conversation

kow3ns
Copy link
Member

@kow3ns kow3ns commented Apr 16, 2019

As discussed, in sig-apps, sig-architecture, steering committee, community meeting, dev ex, etc. We will attempt to clean up the OWNERS files related to SIG Apps and make the responsibilities of approvers and reviewers more general.

  • kow3ns, janetkuo are included as approvers based on being TLs for SIG Apps
  • soltysh, tnozicka are included as approvers based on long term contribution and active participation in this role across much of the API surface
  • smarterclayton, erictune are included as emeritus contributors (both of them are approvers in higher level owners files anyway)

The next step is to clean up our contributor guidelines to make the roles, responsibilities, and contribution guidelines more clear.

/kind cleanup

NONE

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 16, 2019
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 16, 2019
@kow3ns
Copy link
Member Author

kow3ns commented Apr 16, 2019

/sig apps

@janetkuo
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@janetkuo janetkuo added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 16, 2019
@bgrant0607
Copy link
Member

Eventually I think we'll want to organize approvers and reviewers by subproject. In this case "sig-apps" is being used for the workloads-api subproject. If necessary in the future you could make it more explicit, such as "sig-apps-workloads-api-approvers".

Please take a look at the OWNERS files listed in sigs.yaml and check whether the rest should be similarly updated:
https://github.com/kubernetes/community/blob/master/sigs.yaml#L178

But this is a big improvement, so let's merge and iterate.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bgrant0607, kow3ns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0148014 into kubernetes:master Apr 17, 2019
@@ -1,14 +1,8 @@
# See the OWNERS docs at https://go.k8s.io/owners

approvers:
- mikedanese
- janetkuo
- k82cn
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to contribute the volunteer for daemonset :)

@krmayankk
Copy link

i strongly agree that the path is not absolutely clear, and given that development of new features is slowing. its not clear when or how can i become a approver or commiter ? Was there a discussion to define that @kow3ns ?

k8s-ci-robot added a commit that referenced this pull request Jul 9, 2019
Update Sig-Apps OWNERS to aliases in places that were missed in #76669
hiddeco pushed a commit to hiddeco/kubernetes that referenced this pull request Apr 6, 2020
Updates OWNERS files and OWNERS_ALIASES for SIG Apps
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants