Warn to stderr when we encounter PathError listing plugins #76707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
release-note-none
k8s-ci-robot
added
kind/bug
|
/sig cli |
k8s-ci-robot
added
sig/cli
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
soltysh
changed the title
mfojtik
reviewed
Apr 17, 2019
| @@ -116,8 +116,8 @@ func (o *PluginListOptions) Run() error { | |||
| for _, dir := range uniquePathsList(o.PluginPaths) { | |||
| files, err := ioutil.ReadDir(dir) | |||
| if err != nil { | |||
| if _, ok := err.(*os.PathError); ok && strings.Contains(err.Error(), "no such file") { | |||
| klog.V(3).Infof("unable to find directory %q in your PATH. Skipping...", dir) | |||
| if _, ok := err.(*os.PathError); ok { | |||
There was a problem hiding this comment.
if pathErr, ok := err.(*os.PathError); ok {
}
There was a problem hiding this comment.
Not needed, since all I need from the bug is its string.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
New changes are detected. LGTM label has been removed. |
k8s-ci-robot
removed
the
lgtm
|
Fixed bazel, self-tagging back. |
soltysh
added
the
lgtm
|
/retest Review the full test history for this PR. Silence the bot with an |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
We are already skipping errors when reading directories on unix systems, but that condition fails on Windows machines. This PR adds windows exception when reading directory.
Special notes for your reviewer:
/assign @mfojtik @juanvallejo