kubeadm cleanup: master -> control-plane #76918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update pul request
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
area/kubeadm
sig/cluster-lifecycle
|
/assign @neolit123 |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123, xichengliudui The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm cancel |
k8s-ci-robot
removed
the
lgtm
neolit123
reviewed
Apr 23, 2019
cmd/kubeadm/test/util.go
Outdated
| @@ -45,9 +45,9 @@ func SetupTempDir(t *testing.T) string { | |||
| return tmpdir | |||
| } | |||
|
|
|||
| // SetupInitConfigurationFile is a utility function for kubeadm testing that writes a master configuration file | |||
| // SetupInitConfigurationFile is a utility function for kubeadm testing that writes a control-plane configuration file | |||
There was a problem hiding this comment.
@xichengliudui please change:
master configuration file
to InitConfiguration file
[1]
There was a problem hiding this comment.
thanks, has been updated.
cmd/kubeadm/test/util.go
Outdated
| // into /config subfolder of a given temporary directory. | ||
| // The function returns the path of the created master configuration file. | ||
| // The function returns the path of the created control-plane configuration file. |
xichengliudui
force-pushed
the
cleanup-kubeadm-master
branch
from
968c101
to
81c30cb
Compare
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind cleanup
/priority backlog
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: