Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation message: apiServerEndpoints -> apiServerEndpoint #76923

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Fix validation message: apiServerEndpoints -> apiServerEndpoint #76923

merged 1 commit into from
Apr 24, 2019

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented Apr 23, 2019

What type of PR is this?

/kind cleanup
/kind bug

What this PR does / why we need it:
Fix validation message: apiServerEndpoints -> apiServerEndpoint

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1525

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 23, 2019
@SataQiu
Copy link
Member Author

SataQiu commented Apr 23, 2019

/cc @neolit123 @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 23, 2019
neolit123
neolit123 reviewed Apr 23, 2019
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bug! thanks @SataQiu
/priority important-soon

/lgtm
/approve
/hold

@kubernetes/sig-cluster-lifecycle-pr-reviews
@fabriziopandini @rosti
i propose cherry pick for 1.14.

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neolit123, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@rosti
Copy link
Contributor

rosti commented Apr 23, 2019

Thanks for spotting this @SataQiu !
@neolit123 this is just the error message. I don't mind it being cherry-picked though.
@fabriziopandini WDYT?

yagonobre
yagonobre reviewed Apr 24, 2019
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SataQiu
/lgtm

@SataQiu
Copy link
Member Author

SataQiu commented Apr 24, 2019

Thank you all. @neolit123 @rosti @yagonobre
Do I need cherry pick this for 1.14? And can this PR hold cancel now?

@rosti
Copy link
Contributor

rosti commented Apr 24, 2019

@SataQiu feel free to cherry-pick it, you can see how this is done here

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 24, 2019
@rosti
Copy link
Contributor

rosti commented Apr 24, 2019

Actually this needs to go in 1.13 as well (so a couple of cherry-picks are necessary - for 1.13 and 1.14).

@SataQiu
Copy link
Member Author

SataQiu commented Apr 24, 2019

Thanks @rosti
I will try that.

@k8s-ci-robot k8s-ci-robot merged commit 3ba70b9 into kubernetes:master Apr 24, 2019
@neolit123
Copy link
Member

neolit123 commented Apr 24, 2019 •
edited

@SataQiu
we forgot to add a release note instead of NONE

please use:
kubeadm: fix a small bug in the validation of BootstrapTokenDiscovery from JoinConfiguration

This was referenced Apr 24, 2019
Merged
Closed
k8s-ci-robot added a commit that referenced this pull request May 2, 2019
@k8s-ci-robot
Merge pull request #77011 from SataQiu/automated-cherry-pick-of-#7692…
f350b2c 
…3-up-release-1.14

Automated cherry pick of #76923: fix validation message: apiServerEndpoints ->apiServerEndpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@yagonobre yagonobre yagonobre left review comments

@rosti rosti Awaiting requested review from rosti

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@neolit123 neolit123

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm join node display error information not quite incorrect
5 participants
@SataQiu @k8s-ci-robot @rosti @neolit123 @yagonobre