Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use e2e.test binary instead of test/e2e in example invocations #76934

Merged
merged 1 commit into from
Apr 24, 2019

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Apr 23, 2019

What type of PR is this?
/kind documentation

What this PR does / why we need it: the example invocation should use the binary instead of ginkgo because ideally the reader will only need to download the e2e.test binary and not need to clone the repo and/or have ginkgo in their PATH
test/e2e assumes the user has cloned k/k and is working inside it, we want to document the case where the user has downloaded the binary and doesn't need to wait for anything to build

/sig storage

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. sig/storage Categorizes an issue or PR as relevant to SIG Storage. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 23, 2019
@wongma7
Copy link
Contributor Author

wongma7 commented Apr 23, 2019

/cc @pohly
/cc @msau42
PTAL, thank you!!

@k8s-ci-robot k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 23, 2019
./test/e2e \
-- \
-storage.testdriver=/tmp/hostpath-testdriver.yaml
e2e.test -ginkgo.focus='External.Storage.*csi-hostpath' \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One downside is that we lose the parallelism. When I spoke with test-infra, they said that ginkgo -p flag will invoke the e2e binary multiple times with different -ginkgo.prallel.node values to manage the parallelism.

So I think we can just replace "./test/e2e" with the e2e binary in the original command

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original intent was to keep this README.md generic, i.e. not assume that this package is used only in the Kubernetes e2e.test binary. But I guess anyone who does that is able to figure out how to generate an e2e.test binary or invoke ginkgo on the source, so this change is fine.

@k8s-ci-robot k8s-ci-robot removed the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 23, 2019
@wongma7 wongma7 changed the title Use e2e.test binary instead of ginkgo in example invocations Use e2e.test binary instead of test/e2e in example invocations Apr 23, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 23, 2019
@msau42
Copy link
Member

msau42 commented Apr 23, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit c170386 into kubernetes:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants