-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use e2e.test binary instead of test/e2e in example invocations #76934
Conversation
test/e2e/storage/external/README.md
Outdated
./test/e2e \ | ||
-- \ | ||
-storage.testdriver=/tmp/hostpath-testdriver.yaml | ||
e2e.test -ginkgo.focus='External.Storage.*csi-hostpath' \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One downside is that we lose the parallelism. When I spoke with test-infra, they said that ginkgo -p flag will invoke the e2e binary multiple times with different -ginkgo.prallel.node values to manage the parallelism.
So I think we can just replace "./test/e2e" with the e2e binary in the original command
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My original intent was to keep this README.md generic, i.e. not assume that this package is used only in the Kubernetes e2e.test binary. But I guess anyone who does that is able to figure out how to generate an e2e.test
binary or invoke ginkgo
on the source, so this change is fine.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: msau42, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
the example invocation should use the binary instead of ginkgo because ideally the reader will only need to download the e2e.test binary and not need to clone the repo and/or have ginkgo in their PATHtest/e2e assumes the user has cloned k/k and is working inside it, we want to document the case where the user has downloaded the binary and doesn't need to wait for anything to build
/sig storage
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: