Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the dynamic volume limit in GCE PD #76977

Merged
merged 1 commit into from
Apr 30, 2019
Merged

Update the dynamic volume limit in GCE PD #76977

merged 1 commit into from
Apr 30, 2019

Conversation

jingxu97
Copy link
Contributor

Currently GCE PD support 128 maximum disks attached to a node for all
machines types except shared-core. This PR updates the limit number to
date.

@k8s-ci-robot
Copy link
Contributor

@jingxu97: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 24, 2019
@jingxu97 jingxu97 added sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 24, 2019
@jingxu97 jingxu97 requested a review from msau42 April 24, 2019 02:17
msau42
msau42 reviewed Apr 24, 2019
View reviewed changes
pkg/volume/gcepd/gce_pd.go
volumeLimits[util.GCEVolumeLimitKey] = VolumeLimit128
}
}
if strings.HasPrefix(instanceType, "n1-") || strings.HasPrefix(instanceType, "custom-") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have unit tests for this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we didn't add one here mainly because it requires instance type which is hard to get in unit test.

@saad-ali
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingxu97, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2019
@jingxu97
Update the dynamic volume limit in GCE PD
9926815 
Currently GCE PD support 128 maximum disks attached to a node for all
machines types except shared-core. This PR updates the limit number to
date.

Change-Id: Id9dfdbd24763b6b4138935842c246b1803838b78
@msau42
Copy link
Member

msau42 commented Apr 25, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2019
@jingxu97
Copy link
Contributor Author

/test pull-kubernetes-integration

@jingxu97
Copy link
Contributor Author

/test pull-kubernetes-kubemark-e2e-gce-big

@saad-ali saad-ali added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 26, 2019
@saad-ali
Copy link
Member

We should cherry pick to 1.13 and 1.14 once merged

@k8s-ci-robot k8s-ci-robot merged commit 1a52d4f into kubernetes:master Apr 30, 2019
@tpepper
Copy link
Member

tpepper commented May 2, 2019

Cherry picks are:
#77314
#77311

These should have used the cherry pick automation, but appear to be manual.

@tpepper
Copy link
Member

tpepper commented May 2, 2019

Is this a bug fix or a feature?

@jingxu97
Copy link
Contributor Author

jingxu97 commented May 2, 2019

I think it belongs to a bug fix category.

@tpepper
Copy link
Member

tpepper commented May 3, 2019

Can you describe the bug that's fixed? I don't see that in this PR or the proposed cherry picks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@saad-ali saad-ali saad-ali approved these changes

@gnufied gnufied Awaiting requested review from gnufied

Assignees

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jingxu97 @k8s-ci-robot @saad-ali @msau42 @tpepper