Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k8s.gcr.io/k8s-dns-node-cache image version #77029

Merged
merged 1 commit into from
May 7, 2019
Merged

Update k8s.gcr.io/k8s-dns-node-cache image version #77029

merged 1 commit into from
May 7, 2019

Conversation

StevenACoffman
Copy link
Contributor

@StevenACoffman StevenACoffman commented Apr 24, 2019 •
edited

This revised image resolves kubernetes/dns#292 by updating the image from k8s.gcr.io/k8s-dns-node-cache:1.15.1 to k8s.gcr.io/k8s-dns-node-cache:1.15.2

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 24, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @StevenACoffman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Apr 24, 2019
@StevenACoffman
Copy link
Contributor Author

/assign @bowei

@MrHohn
Copy link
Member

MrHohn commented Apr 24, 2019

/ok-to-test
/assign @prameshj

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2019
@StevenACoffman
Copy link
Contributor Author

/retest

@prameshj
Copy link
Contributor

/lgtm
/approve
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 30, 2019
@MrHohn
Copy link
Member

MrHohn commented Apr 30, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, prameshj, StevenACoffman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2019
@prameshj
Copy link
Contributor

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Apr 30, 2019
@prameshj
Copy link
Contributor

Keywords which can automatically close issues and at(@) mentions are not allowed in commit messages.

The list of commits with invalid commit messages:

  • 4da390f Update k8s.gcr.io/k8s-dns-node-cache image version

@StevenACoffman Can you edit the commit message and remove the "/"?

@StevenACoffman
Update k8s-dns-node-cache image version
7f30be7 
This revised image resolves kubernetes dns#292 by updating the image from `k8s-dns-node-cache:1.15.2` to `k8s-dns-node-cache:1.15.2`
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. labels May 1, 2019
@StevenACoffman
Copy link
Contributor Author

@prameshj @MrHohn Thanks for telling me what characters were not allowed, I couldn't find those docs. I have force pushed and need a new LGTM.

@MrHohn
Copy link
Member

MrHohn commented May 1, 2019

Humm I guess this was hit by https://groups.google.com/forum/#!topic/kubernetes-dev/MOnwc8_76wo/discussion. Though the way they detect invalid commit message seem a bit too aggressive?

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 1, 2019
@prameshj
Copy link
Contributor

prameshj commented May 1, 2019

/lgtm

@StevenACoffman
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce-100-performance

@prameshj
Copy link
Contributor

prameshj commented May 7, 2019

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit dca61de into kubernetes:master May 7, 2019
@StevenACoffman StevenACoffman deleted the patch-1 branch May 7, 2019 22:15
This was referenced May 13, 2019
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request May 21, 2019
@k8s-ci-robot
Merge pull request #77829 from prameshj/automated-cherry-pick-of-#770…
4667189 
…29-upstream-release-1.13

Automated cherry pick of #77029: Update k8s-dns-node-cache image version
k8s-ci-robot added a commit that referenced this pull request May 30, 2019
@k8s-ci-robot
Merge pull request #77830 from prameshj/automated-cherry-pick-of-#770…
b1fdb02 
…29-upstream-release-1.14

Automated cherry pick of #77029: Update k8s-dns-node-cache image version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@bowei bowei

@MrHohn MrHohn

@prameshj prameshj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-local-dns crashes on failing to obtain iptables access
5 participants
@StevenACoffman @k8s-ci-robot @MrHohn @prameshj @bowei